Closed Bug 1561254 Opened 6 months ago Closed 4 months ago

Support groupId in constraints

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

67 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

I noticed that we don't return true for groupId from getSupportedConstraints().

It looks like we don't support it in constraints at all. It shouldn't be too hard to add support for this.

This is probably also the reason we're failing the groupId bits of https://wpt.fyi/results/mediacapture-streams/MediaDevices-getUserMedia.https.html.

jib, do you have an idea off the top of your head where code for this should go? I had a quick look for where deviceId is handled but didn't find it. Constraints handling is spread out quite a bit..

Flags: needinfo?(jib)

It should be sufficient to add it to the fitness (and feasibility) distance. Copying what we do for deviceId should do it.

Flags: needinfo?(jib)
Assignee: nobody → apehrson
Status: NEW → ASSIGNED

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:pehrsons, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(apehrson)
Flags: needinfo?(apehrson)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f2eb31348196
Support groupId in constraints. r=achronop,jib,smaug
https://hg.mozilla.org/integration/autoland/rev/c7436c931b20
Clean up tracks after each gUM request in MediaDevices-getUserMedia. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18178 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Upstream PR merged
Depends on: 1571667

Updated BCD in BCD PR 5021 to reflect these being available in Firefox 70. No reference document changes required. Already listed on Firefox 70 for developers.

You need to log in before you can comment on or make changes to this bug.