Support groupId in constraints
Categories
(Core :: WebRTC: Audio/Video, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
I noticed that we don't return true
for groupId
from getSupportedConstraints()
.
It looks like we don't support it in constraints at all. It shouldn't be too hard to add support for this.
Assignee | ||
Comment 1•5 years ago
|
||
This is probably also the reason we're failing the groupId bits of https://wpt.fyi/results/mediacapture-streams/MediaDevices-getUserMedia.https.html.
Assignee | ||
Comment 2•5 years ago
|
||
jib, do you have an idea off the top of your head where code for this should go? I had a quick look for where deviceId is handled but didn't find it. Constraints handling is spread out quite a bit..
Comment 3•5 years ago
|
||
It should be sufficient to add it to the fitness (and feasibility) distance. Copying what we do for deviceId
should do it.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D37692
Comment 6•5 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:pehrsons, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•5 years ago
|
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f2eb31348196 Support groupId in constraints. r=achronop,jib,smaug https://hg.mozilla.org/integration/autoland/rev/c7436c931b20 Clean up tracks after each gUM request in MediaDevices-getUserMedia. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18178 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2eb31348196
https://hg.mozilla.org/mozilla-central/rev/c7436c931b20
Upstream PR merged
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Updated BCD in BCD PR 5021 to reflect these being available in Firefox 70. No reference document changes required. Already listed on Firefox 70 for developers.
Description
•