1561254 - Support groupId in constraints

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Andreas Pehrson [:pehrsons]]

I noticed that we don't return true for groupId from getSupportedConstraints().

It looks like we don't support it in constraints at all. It shouldn't be too hard to add support for this.

Comment 1

[Andreas Pehrson [:pehrsons]]

This is probably also the reason we're failing the groupId bits of https://wpt.fyi/results/mediacapture-streams/MediaDevices-getUserMedia.https.html.

Comment 2

[Andreas Pehrson [:pehrsons]]

jib, do you have an idea off the top of your head where code for this should go? I had a quick look for where deviceId is handled but didn't find it. Constraints handling is spread out quite a bit..

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

It should be sufficient to add it to the fitness (and feasibility) distance. Copying what we do for deviceId should do it.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1561254 - Support groupId in constraints. r?achronop!,jib!,smaug!

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1561254 - Clean up tracks after each gUM request in MediaDevices-getUserMedia. r?jib

Depends on D37692

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:pehrsons, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2eb31348196
Support groupId in constraints. r=achronop,jib,smaug
https://hg.mozilla.org/integration/autoland/rev/c7436c931b20
Clean up tracks after each gUM request in MediaDevices-getUserMedia. r=jib

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18178 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f2eb31348196
https://hg.mozilla.org/mozilla-central/rev/c7436c931b20

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 12

[Eric Shepherd [:sheppy]]

Updated BCD in BCD PR 5021 to reflect these being available in Firefox 70. No reference document changes required. Already listed on Firefox 70 for developers.