1213453 - Implement MediaDeviceInfo.groupId

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

"The origin-unique group identifier for the source of the MediaStreamTrack. Two devices have the same group identifier if they belong to the same physical device; for example, the audio input and output devices representing the speaker and microphone of the same headset would have the same groupId."

http://w3c.github.io/mediacapture-main/getusermedia.html#sec-track-properties

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 2

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27976b9441c5d3000725e95aa95e64b34b3d5bb7

Comment 3

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d84ae771e7ead5722267128541777c42bba5ce3

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1213453 - Add group id in various MediaManager classes. r?pehrsons

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1213453 - Add getters/setters for group id in MediaEngineSource and the derived classes. r?pehrsons

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1213453 - Session-unique group id. r?pehrsons

Spec in [1] mentions: "The browsing session-unique group identifier for the source of the MediaStreamTrack."

[1] https://www.w3.org/TR/mediacapture-streams/#constrainable-properties

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1213453 - Correlate video device group id based on device name. r?pehrsons

Comment 8

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1213453 - Update mochitest to expect group id. r?pehrsons

Comment 9

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf4f656ade77e5478d5213edbee3d8f61ea15fb3

Comment 10

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=096f09816099e9aa523930aafa64133faa7d2e7f

Comment 11

[Alex Chronopoulos [:achronop]]

I would like to put here for reference that the correlation of video and audio devices relies on device names. If an audio device's name contains the name of the video device, then, this video device will take the group id of that audio device. The logic compares the input devices first, if it finds a much then comparison stops, if not it continues with the output devices. In addition to that if there is more than one much we do not attempt to correlate the devices. In general since this is a guess we try to minimize the probability of false positive.

On the other hand the groupId between audio devices that belong to the same physical device is provided by cubeb and it's always correct.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6903f0739e83
Add group id in various MediaManager classes. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/f78c357f2f5f
Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ec1da6bbf1a7
Session-unique group id. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/6208d9e15f3d
Correlate video device group id based on device name. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/118792523194
Update mochitest to expect group id. r=pehrsons

Comment 13

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on MediaEngineDefault.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/f63a07c8426b5f2286870f0b55c2957a8679d60a
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=232626063&revision=1187925231944ef5c076e75e04fb3f321570fe7d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232625594&repo=autoland&lineNumber=18874

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19934e7183f7
Add group id in various MediaManager classes. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/7e561fa634f7
Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/1cac58480c6a
Session-unique group id. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/a90a2cb536f3
Correlate video device group id based on device name. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/75033c11fa3c
Update mochitest to expect group id. r=pehrsons

Comment 15

[Alex Chronopoulos [:achronop]]

Relanded thanks.

Comment 16

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5a5557bda40649437a83f89138c3ea09747cb76

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/19934e7183f7
https://hg.mozilla.org/mozilla-central/rev/7e561fa634f7
https://hg.mozilla.org/mozilla-central/rev/1cac58480c6a
https://hg.mozilla.org/mozilla-central/rev/a90a2cb536f3
https://hg.mozilla.org/mozilla-central/rev/75033c11fa3c

Comment 18

[Chris Mills [:cmills]]

Note to MDN writers:

I've added a note about this to the Fx67 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#Media_Web_Audio_and_WebRTC

In terms of other work:

• The BCD needs updating
• the groupId page needs updating to fill it in a bit (e.g. adding an Example)

Comment 19

[Eric Shepherd [:sheppy]]

Added example to the page https://developer.mozilla.org/en-US/docs/Web/API/MediaDeviceInfo/groupId; also updated and expanded the text slightly (and the example has a long explanation of how it works).

BCD claimed this was added back in Firefox 35 or so, but I've submitted a PR to change it to 67.

Submitted PR 4093 to update BCD

Added a sentence to the existing note on Firefox 67 for developers to explain that the property has existed since Firefox 39, but didn't actually group related items until 67.