1561256 - Disable CRC checks in ogg framing for FUZZING

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Christian Holler (:decoder)]

OGG Framing code has some CRC checks that we should probably disable in FUZZING builds.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1561256 - Disable CRC checks in ogg framing for FUZZING. r?drno

Depends on D35775

Comment 2

[Tyson Smith [:tsmith]]

FWIW Tristan added support upstream here: https://git.xiph.org/?p=ogg.git;a=commit;h=862163e51f87fa5bf57b437dd502052da597c723

Tristan are there any plans to roll out an OGG release any time in the near future?

Comment 3

[Christian Holler (:decoder)]

In that case, we should probably at least import the upstream patch rather than doing this on our own. We can stop using the patch once we import a new release that supports it (I wouldn't want to import a new release just for that).

Comment 4

[Tristan Matthews]

(In reply to Tyson Smith [:tsmith] from comment #2)

FWIW Tristan added support upstream here: https://git.xiph.org/?p=ogg.git;a=commit;h=862163e51f87fa5bf57b437dd502052da597c723

Tristan are there any plans to roll out an OGG release any time in the near future?

The last release was 1.3.3 from November 2017, so I will check with some other xiph folks if it makes sense to do one now.

Comment 5

[Christian Holler (:decoder)]

I think we can still go ahead and land this patch and simply remove it if we decide to import the newer OGG release. I'll land this as soon as I can open up the bugs.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/e2965eee48fe016a62e85d16e4be3f841fc780f9
https://hg.mozilla.org/mozilla-central/rev/e2965eee48fe

Comment 7

[Tristan Matthews]

Just a head up, the latest Ogg release (with --disable-crc) has been published:
https://ftp.osuosl.org/pub/xiph/releases/ogg/libogg-1.3.4.tar.gz