1857843 - Update libogg to 1.3.5

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Chris Peterson [:cpeterson]]

https://gitlab.xiph.org/xiph/ogg/-/tags

We're still using libogg 1.3.3 from 2017-11-07. Two patch versions have been released since:

Version 1.3.5 (2020 June 3)

• Fix unsigned typedef problem on macOS.
• Fix overflow check in ogg_sync_buffer.
• Clean up cmake and autotools build files.
• Remove Symbian and Apple XCode build files.
• Fix documentation cross-reference links.

Version 1.3.4 (2019 August 30)

• Faster slice-by-8 CRC32 implementation.
  see https://lwn.net/Articles/453931/ for motivation.
• Add CMake build.
• Deprecate Visual Studio project files in favor of CMake.
• configure --disable-crc option for fuzzing.
• Various build fixes.
• Documentation and example code fixes.

Comment 1

[Chris Peterson [:cpeterson]]

v1.3.4 added a new --disable-crc option for fuzzing so we can drop one of our in-tree patches, ogg-fuzzing.patch.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1857843 - Prepare local patches for libogg v1.3.5. r?#media-playback-reviewers

• Add new file crctable.h.

• Define new USIZE64 type.

• Remove ogg-fuzzing.patch. This local patch was added in bug 1561256 to disable CRC checking when fuzzing libogg. This patch is no longer necessary because libogg added a --disable-crc option in v1.3.4.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1857843 - Update libogg to v1.3.5. r?#media-playback-reviewers

Version 1.3.5 (2020 June 3)

• Fix unsigned typedef problem on macOS.
• Fix overflow check in ogg_sync_buffer.
• Clean up cmake and autotools build files.
• Remove Symbian and Apple XCode build files.
• Fix documentation cross-reference links.

Version 1.3.4 (2019 August 30)

• Faster slice-by-8 CRC32 implementation.
  see https://lwn.net/Articles/453931/ for motivation.
• Add CMake build.
• Deprecate Visual Studio project files in favor of CMake.
• configure --disable-crc option for fuzzing.
• Various build fixes.
• Documentation and example code fixes.

Depends on D190526

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1857843 - Apply local patches to libogg. r?#media-playback-reviewers

Depends on D190527

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Bug 1857843 - Schedule updatebot to check for new libogg releases. r?padenot

Depends on D190528

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4991bb1bbeb2
Prepare local patches for libogg v1.3.5. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2e57d70e96de
Update libogg to v1.3.5. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/07b2d4dea74c
Apply local patches to libogg. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f93c97fdb97c
Schedule updatebot to check for new libogg releases. r=padenot

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4991bb1bbeb2
https://hg.mozilla.org/mozilla-central/rev/2e57d70e96de
https://hg.mozilla.org/mozilla-central/rev/07b2d4dea74c
https://hg.mozilla.org/mozilla-central/rev/f93c97fdb97c