1561257 - Web page favicons missing from about:performance

Status: VERIFIED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Kestrel]

Attachment: Missing website favicons on about:performance

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8287c3d0c1064096ee7c162060e6615d72722ee0&tochange=3099eaead3bd2d719c3b4a3c700f8677b455cb74

Regressed by Bug 1497202.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Jonas, can you take a look at this one please?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

I guess we need to know how those favicons are loaded and then open up the CSP so those get loaded.

Comment 3

[Jonas Allmann [:jallmann]]

I'll have a look.

Comment 4

[Jonas Allmann [:jallmann]]

Is this as simple as adding img-src data: to the CSP of aboutPerformance.xhtml ?
It seems to work, the icons are back when I apply this change. I'm just not familiar with CSP at all so far, so I just wanted to make sure that is what you meant by "open up the CSP".

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jonas Allmann [:jallmann] from comment #4)

Is this as simple as adding img-src data: to the CSP of aboutPerformance.xhtml ?
It seems to work, the icons are back when I apply this change. I'm just not familiar with CSP at all so far, so I just wanted to make sure that is what you meant by "open up the CSP".

Yep, that's fine with me - thanks!

Comment 6

[Jonas Allmann [:jallmann]]

Attachment: Bug 1561257 - Fix missing favicons from about:performance, r=ckerschb

Amend CSP of aboutPerformance.xhtml to allow loading favicons through data: URIs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91ec7cffedba
Fix missing favicons from about:performance, r=ckerschb

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/91ec7cffedba

Comment 9

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0a1(20190625215814).
Fix verified with 69.0b7 on Windows 10, macOS 10.14, Ubuntu 18.04.