1561435 - Do a formatting pass on mozilla-central using Prettier (the actual change)

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Victor Porof [:vporof][:vp]]

The actual formatting pass for bug 1558517

It's worth pointing out that this series becomes bitrotten on upload. These commits are useful for

1. Dong a full formatting pass close to landing day and making sure we can address all known problems so far.
2. Pinging the appropriate module owners and making sure they see what's going on.

As it stands, this final series serves as a guidance for that's probably extremely close to what's landing on July 5. Rebasing is not an option for generating these commits, which will be re-done.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format devtools/client/, a=automatic-formatting

Depends on D35577

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for devtools/client/, r=standard8

Depends on D35884

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix test failures for devtools/client/, r=standard8

Depends on D35885

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Update `pageError stubs file` after formatting devtools/client/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8

Depends on D35889

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format devtools/server/, a=automatic-formatting

Depends on D35890

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for devtools/server/, r=standard8

Depends on D35891

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix test failures for devtools/server/, r=standard8

Depends on D35892

Comment 8

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format remaining devtools/, a=automatic-formatting

Depends on D35893

Comment 9

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format accessible/, a=automatic-formatting

Depends on D35894

Comment 10

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format build/, a=automatic-formatting

Depends on D35895

Comment 11

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format caps/, a=automatic-formatting

Depends on D35896

Comment 12

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format chrome/, a=automatic-formatting

Depends on D35897

Comment 13

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format config/, a=automatic-formatting

Depends on D35898

Comment 14

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format docshell/, a=automatic-formatting

Depends on D35899

Comment 15

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format editor/, a=automatic-formatting

Depends on D35900

Comment 16

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format extensions/, a=automatic-formatting

Depends on D35901

Comment 17

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format gfx/, a=automatic-formatting

Depends on D35902

Comment 18

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format gradle/, a=automatic-formatting

Depends on D35903

Comment 19

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format hal/, a=automatic-formatting

Depends on D35904

Comment 20

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format image/, a=automatic-formatting

Depends on D35905

Comment 21

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for image/, r=standard8

Depends on D35906

Comment 22

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format intl/, a=automatic-formatting

Depends on D35907

Comment 23

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format ipc/, a=automatic-formatting

Depends on D35908

Comment 24

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format media/, a=automatic-formatting

Depends on D35909

Comment 25

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format memory/, a=automatic-formatting

Depends on D35910

Comment 26

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format mfbt/, a=automatic-formatting

Depends on D35912

Comment 27

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format mobile/, a=automatic-formatting

Depends on D35913

Comment 28

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for mobile/, r=standard8

Depends on D35914

Comment 29

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format modules/, a=automatic-formatting

Depends on D35915

Comment 30

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format mozglue/, a=automatic-formatting

Depends on D35916

Comment 31

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format netwerk/, a=automatic-formatting

Depends on D35917

Comment 32

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for netwerk/, r=standard8

Depends on D35919

Comment 33

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format nsprpub/, a=automatic-formatting

Depends on D35920

Comment 34

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format other-licenses/, a=automatic-formatting

Depends on D35921

Comment 35

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format parser/, a=automatic-formatting

Depends on D35922

Comment 36

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format python/, a=automatic-formatting

Depends on D35923

Comment 37

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format remote/, a=automatic-formatting

Depends on D35924

Comment 38

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for remote/, r=standard8

Depends on D35925

Comment 39

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format layout/, a=automatic-formatting

Depends on D35926

Comment 40

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format security/, a=automatic-formatting

Depends on D35927

Comment 41

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for security/, r=standard8

Depends on D35928

Comment 42

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format services/, a=automatic-formatting

Depends on D35929

Comment 43

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for services/, r=standard8

Depends on D35930

Comment 44

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format servo/, a=automatic-formatting

Depends on D35931

Comment 45

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format startupcache/, a=automatic-formatting

Depends on D35933

Comment 46

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format storage/, a=automatic-formatting

Depends on D35934

Comment 47

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for storage/, r=standard8

Depends on D35935

Comment 48

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format taskcluster/, a=automatic-formatting

Depends on D35936

Comment 49

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for taskcluster/, r=standard8

Depends on D35938

Comment 50

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format tools/, a=automatic-formatting

Depends on D35939

Comment 51

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for tools/, r=standard8

Depends on D35940

Comment 52

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format uriloader/, a=automatic-formatting

Depends on D35941

Comment 53

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format view/, a=automatic-formatting

Depends on D35942

Comment 54

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format widget/, a=automatic-formatting

Depends on D35943

Comment 55

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format xpcom/, a=automatic-formatting

Depends on D35944

Comment 56

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format xpfe/, a=automatic-formatting

Depends on D35945

Comment 57

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for browser/, r=standard8

Comment 58

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format dom/, a=automatic-formatting

Depends on D35950

Comment 59

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for dom/, r=standard8

Depends on D35951

Comment 60

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix test failures for dom/, r=standard8

Depends on D35952

Comment 61

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Avoid formatting sensitive fixtures for dom/, r=standard8

Depends on D35953

Comment 62

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for toolkit/, r=standard8

Comment 63

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format js/, a=automatic-formatting

Comment 64

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format testing/, a=automatic-formatting

Comment 65

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for testing/, r=standard8

Depends on D35962

Comment 66

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Reposition comments in gfx/, r=kats

Comment 67

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/actors/, a=automatic-formatting

Comment 68

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/base/, a=automatic-formatting

Depends on D36040

Comment 69

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/components/, a=automatic-formatting

Depends on D36041

Comment 70

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/extensions/, a=automatic-formatting

Depends on D36042

Comment 71

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/modules/, a=automatic-formatting

Depends on D36045

Comment 72

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format browser/tools/, a=automatic-formatting

Depends on D36046

Comment 73

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/actors, a=automatic-formatting

Comment 74

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/components/, a=automatic-formatting

Depends on D36050

Comment 75

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/content/, a=automatic-formatting

Depends on D36052

Comment 76

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/crashreporter/, a=automatic-formatting

Depends on D36053

Comment 77

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/forgetaboutsite/, a=automatic-formatting

Depends on D36054

Comment 78

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/modules/, a=automatic-formatting

Depends on D36055

Comment 79

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/mozapps/, a=automatic-formatting

Depends on D36056

Comment 80

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/profile/, a=automatic-formatting

Depends on D36057

Comment 81

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Format toolkit/xre/, a=automatic-formatting

Depends on D36058

Comment 82

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix test failures for toolkit/, r=standard8

Depends on D35955

Comment 84

[Victor Porof [:vporof][:vp]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3af08bc51a3ee091df076b78c4b8386fec7a683c

Comment 85

[Victor Porof [:vporof][:vp]]

Looks like I finally managed to tame the (many!) failures, except for test_resource_monitor.py which seems to pass locally but not on try. Investigating further.

Comment 86

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Fix linting errors for accessible/, r=standard8

Depends on D35895

Comment 87

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1561435 - Update `pageError stubs file` after formatting testing/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8

Depends on D35963

Comment 88

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/59f51c65dbf0
Format accessible/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/e78cfc623256
Fix linting errors for accessible/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/fb99af508d47
Format browser/actors/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/aa12d9e8a4f1
Format browser/base/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/4381f16ec994
Format browser/components/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/39b4804c504c
Format browser/extensions/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/e8225f3e114b
Format browser/modules/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/c577840a8063
Format browser/tools/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/feb526768691
Fix linting errors for browser/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/dfb231a91cc3
Format build/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/0513b22f434f
Format caps/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/0bbd90cb5368
Format chrome/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/a26eba0ab47d
Format config/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/f63d6dbcb243
Format docshell/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/f3b422727b92
Format dom/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/23e4bd9e52e4
Fix linting errors for dom/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/4e7dbc3bfab6
Fix test failures for dom/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/6fc1f92ea98d
Avoid formatting sensitive fixtures for dom/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/05c53825de05
Format editor/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/599bcfdc8eee
Format extensions/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/1982faa9eafa
Format gfx/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/516d28fb9aeb
Reposition comments in gfx/, r=kats
https://hg.mozilla.org/mozilla-central/rev/8075dd053054
Format gradle/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/c822e46e3c16
Format hal/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/bcb509a14173
Format image/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/62a5aeaf0dff
Fix linting errors for image/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/928cc5362416
Format intl/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d381ac512d90
Format ipc/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/4b8b3495f071
Format js/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/a85aec1aa92d
Format layout/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/b70cef7801ae
Format media/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/fe31b52c5ca4
Format memory/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/5f1dccb626a0
Format mfbt/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d9ed067030a5
Format mobile/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d2c1fb7f1c91
Fix linting errors for mobile/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/5b0e589285f7
Format modules/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/b0329baff860
Format mozglue/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d9a6985d5acd
Format netwerk/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/9d81554c410b
Fix linting errors for netwerk/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/17cf3eb8f0ee
Format nsprpub/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d020968b3858
Format other-licenses/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/ca57fd3d5fa5
Format parser/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/aa12389b6701
Format python/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/07ce31daca13
Format remote/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/1b243b4ec0ac
Fix linting errors for remote/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/8062fdb43427
Format security/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/6ceb52b9a600
Fix linting errors for security/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/854373e1ab9e
Format services/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/dcd5e22d3838
Fix linting errors for services/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/d40e8f24f114
Format servo/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/168bec380944
Format startupcache/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/f6fff703eb26
Format storage/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/1e3121039456
Fix linting errors for storage/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/0df3e32ec2fb
Format taskcluster/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/1a154e62b830
Fix linting errors for taskcluster/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/51c89fcec893
Format testing/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/b0c9aa13768f
Fix linting errors for testing/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/799f4b64f756
Update `pageError stubs file` after formatting testing/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8
https://hg.mozilla.org/mozilla-central/rev/a331a8e092dc
Format toolkit/actors, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/becae3f8f590
Format toolkit/components/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/e8bd1069715d
Format toolkit/content/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/7f9969319147
Format toolkit/crashreporter/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/b8561ed633b2
Format toolkit/forgetaboutsite/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/e5be4c59b7f1
Format toolkit/modules/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/58fd5776802a
Format toolkit/mozapps/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/8be6c7ab9d27
Format toolkit/profile/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/d8d9a53c4c13
Format toolkit/xre/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/aaadca9b3125
Fix linting errors for toolkit/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/970453d65b19
Fix test failures for toolkit/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/2106cbe66fff
Format tools/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/c97b04d9be60
Fix linting errors for tools/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/52e9f4dddabf
Format uriloader/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/06715c4f165d
Format view/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/b53e2f4066e8
Format widget/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/285c79c476cd
Format xpcom/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/0e52ffb26be7
Format xpfe/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/c7a227149b8f
Format devtools/client/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/25b5e323c763
Fix linting errors for devtools/client/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/6d3e80bc6e5d
Fix test failures for devtools/client/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/84db9ca75c29
Update `pageError stubs file` after formatting devtools/client/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8
https://hg.mozilla.org/mozilla-central/rev/dd987949a7c2
Format devtools/server/, a=automatic-formatting
https://hg.mozilla.org/mozilla-central/rev/ab820f7fdd38
Fix linting errors for devtools/server/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/80230ef725c4
Fix test failures for devtools/server/, r=standard8
https://hg.mozilla.org/mozilla-central/rev/041abaa4aa85
Format remaining devtools/, a=automatic-formatting, CLOSED TREE