1561577 - Hitting the Escape key to close the shortcuts modal also toggles the Split Console

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Florens Verschelde :fvsch]

We added the ability to close the Shortcuts modal with the Escape key to be consistent with other modal UI in Debugger, but it was probably not tested in a Firefox build.

Steps to reproduce:

1. In Firefox Nightly, open the Debugger
2. On the Welcome page, click "Show all shortcuts"
3. Hit the Escape key

Expected result:

• The shortcuts modal is closed

Actual result:

• The shortcuts modal is closed
• The Split Console is toggled

We should probably stop the event's propagation or something similar.

Comment 1

[Jason Laster [:jlast]]

Yes. This is a regression. We are really careful with escape because it is context specific.

Comment 2

[Alex R.]

I think I've got a quick one-line fix for this... I'll go ahead and submit a patch for review.

Comment 3

[Alex R.]

Attachment: prevent default when esc is pressed on shortcutsModal

Prevent toggling open Split Console with escape is pressed to toggle shortcutsModal closed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33eca9689b58
prevent default when esc is pressed on shortcutsModal r=jlast

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/33eca9689b58