Closed Bug 156169 Opened 22 years ago Closed 22 years ago

bug # in attachment editor should be styled like it is everywhere else

Categories

(Bugzilla :: Attachments & Requests, enhancement)

2.17
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: timeless, Assigned: jouni)

Details

Attachments

(1 file, 1 obsolete file)

3.95 KB, patch
bugreport
: review+
Details | Diff | Splinter Review
i loaded 6 tabs w/ edit attachment pages but i can't tell if the bugs are
enhancements or resolved or ...
So is your point that you'd like to see the bug number striked out if it's resolved?
Severity: normal → enhancement
err. The <title> (which I presume is what you're referring to) can't be styled,
sort of by defintion.

Orare you talking about something else?
This is a special case of stuff covered in bug 93220.
Depends on: 93200
Attached patch v1 (obsolete) — Splinter Review
Add use of GetBugLink to create/edit attachment screens.
This bug deals with the bug number shown in the "h1" of the standard page header.

>This is a special case of stuff covered in bug 93220.

Yes, but not blocked by it. Since there's no work going on in that bug, we might
just as well fix this instance separately.

Taking, adding keywords and removing the dependency (which was mistyped anyway :-)).
Assignee: myk → jouni
No longer depends on: 93200
Keywords: patch, review
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
Attachment #90594 - Flags: review+
Component: Creating/Changing Bugs → attachment and request management
Comment on attachment 90594 [details] [diff] [review]
v1

This has bitrotted a bit
On the edit attachment page, there is a space missing between "for" and "Bug"
and some of the links don't work.

The code looks good and probably just needs a careful merge to be ready to
re-review.
Attachment #90594 - Flags: review-
Keywords: review
Attached patch v2Splinter Review
Fixed the bitrot. I also extended the scope of this stuff to multiple
attachment viewer, since it's practically the same code anyway.
Attachment #90594 - Attachment is obsolete: true
Comment on attachment 111074 [details] [diff] [review]
v2

Joel, can you take another look at this? Your last review comments and the
bitrot has been fixed.
Attachment #111074 - Flags: review?(bugreport)
Attachment #111074 - Flags: review?(bugreport) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.36; previous revision: 1.35
done
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: patch
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: