Closed Bug 156173 Opened 22 years ago Closed 22 years ago

"Save Image" context menu command in Composer doesn't work

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2alpha

People

(Reporter: bailunchuan, Assigned: cmanske)

References

Details

(Whiteboard: EDITORBASE)

Attachments

(1 file, 1 obsolete file)

patch v2
6.34 KB, patch
Brade
: review+
alecf
: superreview+
Details | Diff | Splinter Review
in the browser: when File/edit page, right-click the image, in the menu pop up, the Save Image...couldn't work.
confirming...happens on both 7/15 branch and 7/16 trunk...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Robin: please release note the fact that this command doesn't work
Assignee: syd → cmanske
Note added to release notes tracking bug 155243.
Status: NEW → ASSIGNED
Summary: Save Image in Editor couldn't work → "Save Image" context menu command in Composer doesn't work
Target Milestone: --- → mozilla1.2alpha
Attached patch patch v1 (obsolete) — — Splinter Review
I think we should simply remove the "Save Image" item from the menu.
Keywords: nsbeta1, patch, review
Whiteboard: [FIX IN HAND] need r=,sr=
Comment on attachment 94098 [details] [diff] [review] patch v1 I don't see where the actual menu item is removed from a xul file. Also, are we sure we want to remove the menu item? Why not just make it work by fixing the SaveURL call?
Attachment #94098 - Flags: needs-work+
Attached patch patch v2 — — Splinter Review
oops! XUL file missing in last patch. The reason I didn't simply fix "Save Image" is because it looked extremely tricky. The browser now has many layers of objects interpossed in their command handling, making it very difficult for other modules to use. After thinking about how crowded our context menus are, it didn't seem like a command that we really needed. In Editing context, you usually have the images and don't need to download them.
Attachment #94098 - Attachment is obsolete: true
Comment on attachment 94222 [details] [diff] [review] patch v2 r=brade
Attachment #94222 - Flags: review+
Whiteboard: [FIX IN HAND] need r=,sr= → [FIX IN HAND] need sr=
Comment on attachment 94222 [details] [diff] [review] patch v2 sr=alecf
Attachment #94222 - Flags: superreview+
Whiteboard: [FIX IN HAND] need sr= → [FIX IN HAND]
*** Bug 161793 has been marked as a duplicate of this bug. ***
nominating....starting to get DUPS on this bug...
Whiteboard: [FIX IN HAND] → [FIX IN HAND] EDITORBASE
checked into 1.2 trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND] EDITORBASE → EDITORBASE
verified in 9/5 trunk build.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: