Closed Bug 1561827 Opened 1 year ago Closed 1 year ago

Flash plugin's `File` and `MIME Types` fields are empty in HTML about:addons

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- verified
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 + verified
firefox69 --- verified

People

(Reporter: cpeterson, Assigned: robwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

[Tracking Requested - why for this release]:

This bug is a regression in Firefox 68 from bug 1555012.

Steps to reproduce

  1. Open about:addons.
  2. Click "Plugins".
  3. Click "Shockwave Flash".
  4. Click "Options".

Expected results

The File field's value should be something like NPSWF64_32_0_0_207.dll. The MIME Types field's value should be application/x-shockwave-flash (Adobe Flash movie: swf), application/futuresplash (FutureSplash movie: spl).

Actual results

The File and MIME Types fields have no values. See the attached screenshot.

Rob can you have a look and triage this? Thanks!

Flags: needinfo?(rob)

Patch incoming.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Flags: needinfo?(rob)

The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.

Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.

Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/5d560c5e357d
Move pluginPrefs initialization to pluginPrefs.js r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9074495 [details]
Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js

Beta/Release Uplift Approval Request

  • User impact if declined: The "File" and "MIME types" rows of the flash plugin are empty instead of showing the expected metadata.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch moves around existing code and includes a unit test that verifies the expected behavior.
  • String changes made/needed: none
Attachment #9074495 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9074495 [details]
Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js

HTML about:addons fix for plugin prefs, approved for 68 rc1

Attachment #9074495 - Flags: approval-mozilla-release+
Attachment #9074495 - Flags: approval-mozilla-esr68+
Attachment #9074495 - Flags: approval-mozilla-beta?

The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.

Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.

QA Whiteboard: [qa-triaged]

Verified as fixed in FF 68.0 and 69.0a1 (2019-07-02) on Win10x64 and macOS 10.13.6

The File field's value on macOS is "Flash Player.plugin" instead of something something like "NPSWF64_32_0_0_207.dll" how is for Windows.

Please let me know if this is the expected behavior.

Flags: needinfo?(rob)

(n reply to Victor Carciu from comment #14)

The File field's value on macOS is "Flash Player.plugin" instead of something something like "NPSWF64_32_0_0_207.dll" how is for Windows.

Please let me know if this is the expected behavior.

Looks good to me.

Flags: needinfo?(rob)

Verified as fixed also in 68.0esr (64-bit) on Win10x64 and macOS 10.13.6

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.