Test that proxy.onRequest works with WebSocket requests (ws/wss)
Categories
(WebExtensions :: Request Handling, task)
Tracking
(firefox69 fixed)
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
Details
Attachments
(1 file)
proxy.onRequest supports http, https, and also ftp (as of bug 1552248).
MatchPattern does not only support those, but also ws(s).
Let's add test coverage for proxying WebSocket requests via the proxy.onRequest API, to ensure that it works, and continues to work.
|
Assignee | |
Comment 1•5 years ago
|
||
The main purpose of this test is to verify that the proxy.onRequest
event captures WebSocket requests.
We also get the following additional coverage for free:
-
actual requests with wss: scheme (the only other extension test
that uses WebSocket, via ws:, is test_ext_webRequest_webSocket.js). -
intercepting requests of other extensions via the proxy API.
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/02beb3c28e87 Add test for WebSocket requests in proxy.onRequest r=mixedpuppy
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
|
||
From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "
|
|
Assignee | |
Updated•5 years ago
|
Description
•