Closed Bug 1561911 Opened 1 year ago Closed 2 months ago

Unhandled rejected promise from `new ReadableStream(source)` if source.start() rejects

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jorendorff, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

This little test case passes, but leaves an unhandled rejected promise somewhere:

const rs = new ReadableStream({
  start() {
    return Promise.reject(new Error("testing error behavior"));
  }
});

rs.getReader().read().then(ok => print("FAIL"), err => print("PASS"));

Note that the test passes. So it is not the original rejected promise that isn't being handled. The stream itself must be creating another promise, rejecting it, and no one's handling that.

testing/web-platform/tests/streams/readable-streams/default-reader.any.js tests for this. It was silently passing in Firefox until June 4 when bug 1525554 landed.

Type: task → defect
Priority: -- → P2

This is probably the same root cause. I spent a day debugging a Web extension that was spewing unhandled rejection errors (error reporting libraries like bugsnag report all unhandledrejections).

My minimized test case looks like the following:

window.onunhandledrejection = err => {
  console.log('onunhandledrejection');
  console.log(err);
};

(async () => {
  const stream = new ReadableStream({
    async start(controller) {
      await new Promise(resolve => resolve());
      controller.error(new Error('Error!'));
      controller.close();
    }
  });

  let reader;
  try {
    reader = stream.getReader();
  } catch(e) {
    console.log('Caught error getting reader');
    return;
  }
 
  try {
    await reader.read();
  } catch(e) {
    console.log('Caught error reading');
  }
})();

(Codepen)

Produces an unhandledrejection in Nightly but not in Chrome.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Yes, they have the same behavior.

In the comment #0 case, start returns a rejected promise, and it performs
ReadableStreamDefaultControllerError

https://streams.spec.whatwg.org/#set-up-readable-stream-default-controller

3.10.11. SetUpReadableStreamDefaultController
(stream, controller, startAlgorithm, pullAlgorithm, cancelAlgorithm,
highWaterMark, sizeAlgorithm ) throws
...
9. Let startResult be the result of performing startAlgorithm.
(This may throw an exception.)
...
12. Upon rejection of startPromise with reason r,
a. Perform ! ReadableStreamDefaultControllerError(controller, r).

and it performs ReadableStreamError.

https://streams.spec.whatwg.org/#readable-stream-error

3.10.7. ReadableStreamDefaultControllerError ( controller, e ) nothrow
5. Perform ! ReadableStreamError(stream, e).

In comment #1 case,
start calls ReadableStreamDefaultController.prototype.error, that performs
ReadableStreamDefaultControllerError like above.

https://streams.spec.whatwg.org/#rs-default-controller-error

3.9.4 Properties of the ReadableStreamDefaultController prototype
3.9.4.4. error(e)
...
2. Perform ! ReadableStreamDefaultControllerError(this, e).

and then it calls ReadableStreamDefaultController.prototype.close,
and it throws because the stream is already closed

https://streams.spec.whatwg.org/#rs-default-controller-close

3.9.4 Properties of the ReadableStreamDefaultController prototype
3.9.4.2. close()
...
2. If ! ReadableStreamDefaultControllerCanCloseOrEnqueue(this) is false, throw a TypeError exception.

https://streams.spec.whatwg.org/#readable-stream-default-controller-can-close-or-enqueue

3.10.10. ReadableStreamDefaultControllerCanCloseOrEnqueue ( controller ) nothrow
...
2. If controller.[[closeRequested]] is false and state is "readable", return true.
3. Otherwise, return false.

So the start returns rejected promise (given it's async function) and it goes
to 3.10.11 step 12.a,
and there performing ReadableStreamDefaultControllerError again does nothing.

https://streams.spec.whatwg.org/#readable-stream-default-controller-error

3.10.7. ReadableStreamDefaultControllerError ( controller, e ) nothrow
...
2. If stream.[[state]] is not "readable", return.

Then, the issue is the [[closedPromise]] rejected inside ReadableStreamError.

https://streams.spec.whatwg.org/#readable-stream-error

3.5.6. ReadableStreamError ( stream, e ) nothrow
...
9. Reject reader.[[closedPromise]] with e.

That's the promise returned by ReadableStreamDefaultReader.prototype.closed getter.

https://streams.spec.whatwg.org/#default-reader-closed

3.6.4.1. get closed
...
2. Return this.[[closedPromise]].

The promise isn't handled anywhere, and I guess that's not something strange.
So, we shouldn't register that to unhandled promise list.

fwiw, the unhandled rejection goes away with the following (NOT FOR PRODUCTION!):

reader.closed.catch(e => e);

sorry, I overlooked 3.5.6 step 10

https://streams.spec.whatwg.org/#readable-stream-error

3.5.6. ReadableStreamError ( stream, e ) nothrow
...
9. Reject reader.[[closedPromise]] with e.
10. Set reader.[[closedPromise]].[[PromiseIsHandled]] to true.

there we just have to remove it from unhandled rejection.
just like the following
https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/js/src/builtin/streams/ReadableStreamReader.cpp#110-112

    // Step c. Set reader.[[closedPromise]].[[PromiseIsHandled]] to true.
    promise->as<PromiseObject>().setHandled();
    cx->runtime()->removeUnhandledRejectedPromise(cx, promise);

That lines up with what I understood from https://github.com/whatwg/streams/issues/547

SetPromiseIsHandled performs "Set promise.[[PromiseIsHandled]] to true.", with
removing unhandled rejection.

Fixed the following steps to use SetPromiseIsHandled:

  • 3.8.4. ReadableStreamReaderGenericInitialize Step 6.c
  • 3.8.5. ReadableStreamReaderGenericRelease step 5
  • 4.4.13. WritableStreamRejectCloseAndClosedPromiseIfNeeded step 4.b
  • 4.5.3. new WritableStreamDefaultWriter step 7.b
  • 4.5.3. new WritableStreamDefaultWriter step 9.d
  • 4.5.3. new WritableStreamDefaultWriter step 9.f
  • 4.6.5. WritableStreamDefaultWriterEnsureClosedPromiseRejected step 3
  • 4.6.6. WritableStreamDefaultWriterEnsureReadyPromiseRejected step 3

Depends on D55613

Implemented 3.5.6. ReadableStreamError step 10.

Depends on D55614

There are 2 more places that modifies "[[PromiseIsHandled]]" inside Streams spec:

  • 3.2.5.5. pipeThrough step 9
  • 3.4.10. ReadableStreamTee 12.d

the former is NYI ( https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/js/src/builtin/streams/ReadableStream.cpp#338-342 ),
and the latter is outdated (bug 1561897)

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/b4e45bf8c0c4
Part 1: Update ReadableStreamReaderGenericInitialize steps. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/885ddf6cbc22
Part 2: Add SetPromiseIsHandled. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/38d79445e3c1
Part 3: Set closedPromise.[[PromiseIsHandled]] to true in ReadableStreamError. r=jwalden

Backed out 3 changesets (Bug 1561911) for /streams/readable-streams/* failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=e9c60f90975a55b24625b9dbbc7f6bb50ba1b345&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-web-platform-tests-e10s-3%2Cw%28wpt3%29&tochange=dfa7714e0543412adf6ee9e065069f9fe5d1b025&selectedJob=279486913

Backout link: https://hg.mozilla.org/integration/autoland/rev/dfa7714e0543412adf6ee9e065069f9fe5d1b025

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279486913&repo=autoland&lineNumber=5212

[task 2019-12-04T03:12:45.519Z] 03:12:45 INFO - TEST-START | /streams/readable-streams/default-reader.any.serviceworker.html
[task 2019-12-04T03:12:45.520Z] 03:12:45 INFO - Clearing pref javascript.options.streams
[task 2019-12-04T03:12:45.535Z] 03:12:45 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:12:45.538Z] 03:12:45 INFO - Closing window 122
[task 2019-12-04T03:12:46.276Z] 03:12:46 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/default-reader.any.serviceworker.html | expected ERROR
[task 2019-12-04T03:12:46.276Z] 03:12:46 INFO - TEST-INFO expected ERROR | took 758ms
[task 2019-12-04T03:12:47.351Z] 03:12:47 INFO - Closing logging queue
[task 2019-12-04T03:12:47.351Z] 03:12:47 INFO - queue closed
[task 2019-12-04T03:12:47.368Z] 03:12:47 INFO - Setting up ssl
[task 2019-12-04T03:12:47.464Z] 03:12:47 INFO - certutil |
[task 2019-12-04T03:12:47.540Z] 03:12:47 INFO - certutil |
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO - certutil |
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO -
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO - web-platform-tests CT,,
[task 2019-12-04T03:12:47.547Z] 03:12:47 INFO -
[task 2019-12-04T03:12:50.266Z] 03:12:50 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:12:51.528Z] 03:12:51 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmpAV3yCOpidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:12:52.911Z] 03:12:52 INFO - Starting runner
[task 2019-12-04T03:12:53.024Z] 03:12:53 INFO - TEST-START | /streams/readable-streams/default-reader.any.html
[task 2019-12-04T03:12:53.040Z] 03:12:53 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:12:53.667Z] 03:12:53 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/default-reader.any.html | expected ERROR
[task 2019-12-04T03:12:53.668Z] 03:12:53 INFO - TEST-INFO expected ERROR | took 645ms
[task 2019-12-04T03:12:54.949Z] 03:12:54 INFO - Closing logging queue
[task 2019-12-04T03:12:54.949Z] 03:12:54 INFO - queue closed
[task 2019-12-04T03:12:54.957Z] 03:12:54 INFO - Setting up ssl
[task 2019-12-04T03:12:55.234Z] 03:12:55 INFO - certutil |
[task 2019-12-04T03:12:55.309Z] 03:12:55 INFO - certutil |
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO - certutil |
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO -
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO - web-platform-tests CT,,
[task 2019-12-04T03:12:55.325Z] 03:12:55 INFO -
[task 2019-12-04T03:12:58.035Z] 03:12:58 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:12:59.283Z] 03:12:59 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmpfgSNCPpidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:13:00.767Z] 03:13:00 INFO - Starting runner
...
[task 2019-12-04T03:13:16.196Z] 03:13:16 INFO - TEST-START | /streams/readable-streams/tee.any.serviceworker.html
[task 2019-12-04T03:13:16.197Z] 03:13:16 INFO - Clearing pref javascript.options.streams
[task 2019-12-04T03:13:16.212Z] 03:13:16 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:13:16.220Z] 03:13:16 INFO - Closing window 90
[task 2019-12-04T03:13:16.983Z] 03:13:16 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/tee.any.serviceworker.html | expected ERROR
[task 2019-12-04T03:13:16.983Z] 03:13:16 INFO - TEST-INFO expected ERROR | took 788ms
[task 2019-12-04T03:13:18.065Z] 03:13:18 INFO - Closing logging queue
[task 2019-12-04T03:13:18.065Z] 03:13:18 INFO - queue closed
[task 2019-12-04T03:13:18.068Z] 03:13:18 INFO - Setting up ssl
[task 2019-12-04T03:13:18.164Z] 03:13:18 INFO - certutil |
[task 2019-12-04T03:13:18.245Z] 03:13:18 INFO - certutil |
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO - certutil |
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO -
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO - web-platform-tests CT,,
[task 2019-12-04T03:13:18.260Z] 03:13:18 INFO -
[task 2019-12-04T03:13:20.972Z] 03:13:20 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:13:22.222Z] 03:13:22 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmpajAi7qpidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:13:23.710Z] 03:13:23 INFO - Starting runner
[task 2019-12-04T03:13:23.866Z] 03:13:23 INFO - TEST-START | /streams/readable-streams/tee.any.sharedworker.html
[task 2019-12-04T03:13:23.887Z] 03:13:23 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:13:24.573Z] 03:13:24 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/tee.any.sharedworker.html | expected ERROR
[task 2019-12-04T03:13:24.573Z] 03:13:24 INFO - TEST-INFO expected ERROR | took 709ms
[task 2019-12-04T03:13:25.660Z] 03:13:25 INFO - Closing logging queue
[task 2019-12-04T03:13:25.660Z] 03:13:25 INFO - queue closed
[task 2019-12-04T03:13:25.668Z] 03:13:25 INFO - Setting up ssl
[task 2019-12-04T03:13:25.776Z] 03:13:25 INFO - certutil |
[task 2019-12-04T03:13:25.852Z] 03:13:25 INFO - certutil |
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO - certutil |
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO -
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO - web-platform-tests CT,,
[task 2019-12-04T03:13:25.859Z] 03:13:25 INFO -
[task 2019-12-04T03:13:28.674Z] 03:13:28 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:13:29.923Z] 03:13:29 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmp9vREK3pidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:13:31.413Z] 03:13:31 INFO - Starting runner
[task 2019-12-04T03:13:31.544Z] 03:13:31 INFO - TEST-START | /streams/readable-streams/tee.any.html
[task 2019-12-04T03:13:31.564Z] 03:13:31 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:13:32.333Z] 03:13:32 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/tee.any.html | expected ERROR
[task 2019-12-04T03:13:32.333Z] 03:13:32 INFO - TEST-INFO expected ERROR | took 789ms
[task 2019-12-04T03:13:33.544Z] 03:13:33 INFO - Closing logging queue
[task 2019-12-04T03:13:33.545Z] 03:13:33 INFO - queue closed
[task 2019-12-04T03:13:33.552Z] 03:13:33 INFO - Setting up ssl
[task 2019-12-04T03:13:33.676Z] 03:13:33 INFO - certutil |
[task 2019-12-04T03:13:33.757Z] 03:13:33 INFO - certutil |
[task 2019-12-04T03:13:33.772Z] 03:13:33 INFO - certutil |
[task 2019-12-04T03:13:33.772Z] 03:13:33 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:13:33.772Z] 03:13:33 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:13:33.773Z] 03:13:33 INFO -
[task 2019-12-04T03:13:33.773Z] 03:13:33 INFO - web-platform-tests CT,,
[task 2019-12-04T03:13:33.773Z] 03:13:33 INFO -
[task 2019-12-04T03:13:36.515Z] 03:13:36 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:13:37.770Z] 03:13:37 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmp8qSKYZpidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:13:39.366Z] 03:13:39 INFO - Starting runner
[task 2019-12-04T03:13:39.502Z] 03:13:39 INFO - TEST-START | /streams/readable-streams/tee.any.worker.html
[task 2019-12-04T03:13:39.539Z] 03:13:39 INFO - Setting pref javascript.options.streams (true)
[task 2019-12-04T03:13:40.235Z] 03:13:40 INFO - TEST-UNEXPECTED-OK | /streams/readable-streams/tee.any.worker.html | expected ERROR
[task 2019-12-04T03:13:40.235Z] 03:13:40 INFO - TEST-INFO expected ERROR | took 735ms
[task 2019-12-04T03:13:41.320Z] 03:13:41 INFO - Closing logging queue
[task 2019-12-04T03:13:41.320Z] 03:13:41 INFO - queue closed
[task 2019-12-04T03:13:41.335Z] 03:13:41 INFO - Setting up ssl
[task 2019-12-04T03:13:41.436Z] 03:13:41 INFO - certutil |
[task 2019-12-04T03:13:41.517Z] 03:13:41 INFO - certutil |
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO - certutil |
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO - Certificate Nickname Trust Attributes
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO - SSL,S/MIME,JAR/XPI
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO -
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO - web-platform-tests CT,,
[task 2019-12-04T03:13:41.532Z] 03:13:41 INFO -
[task 2019-12-04T03:13:44.267Z] 03:13:44 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-12-04T03:13:45.529Z] 03:13:45 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmpbRKhEypidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-12-04T03:13:47.133Z] 03:13:47 INFO - Starting runner
...

Flags: needinfo?(arai.unmht)

forgot to remove expected failure.
will fix shortly

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/c4b38fbe9db0
Part 1: Update ReadableStreamReaderGenericInitialize steps. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/fc547f512ed8
Part 2: Add SetPromiseIsHandled. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/4c5f5aad4fd7
Part 3: Set closedPromise.[[PromiseIsHandled]] to true in ReadableStreamError. r=jwalden
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.