1561955 - Dark mode for the Protection Report (about:protections)

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P3)

Description

[Erica Wright [:ewright]]

Create and implement designs for dark mode for about:protections.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1561955 - Make about:protections support dark mode.

Comment 3

[Tim Nguyen :ntim]

Attachment: Screenshot of patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13bb9ba5f69b
Make about:protections support dark mode. r=ewright,johannh

Comment 5

[Tim Nguyen :ntim]

I requested a backout as mtigley added some comments I haven't addressed: https://hg.mozilla.org/integration/autoland/rev/4c2aaf3c3d25

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbde5a300f43
Make about:protections support dark mode. r=ewright,mtigley,johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe65e1f85f74
Run ./mach eslint on protections JS files to fix lint errors. r=eslint-fix CLOSED TREE

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bbde5a300f43
https://hg.mozilla.org/mozilla-central/rev/fe65e1f85f74

Comment 9

[Micah [:mtigley] (she/her)]

The changes for the Monitor card's font-sizes seemed to be reverted after the push. This was the original diff with the correct changes: https://phabricator.services.mozilla.com/D38210?id=135958

Comment 10

[Tim Nguyen :ntim]

(In reply to Micah Tigley [:mtigley] from comment #9)

The changes for the Monitor card's font-sizes seemed to be reverted after the push. This was the original diff with the correct changes: https://phabricator.services.mozilla.com/D38210?id=135958

Ah, thanks for noticing that. This is pretty strange since Lando mentioned diff 135965 was landed and the latest diff on phabricator is Diff 135958.