Dark mode for the Protection Report (about:protections)
Categories
(Firefox :: Protections UI, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ewright, Assigned: ntim)
References
(Blocks 1 open bug)
Details
(Whiteboard: [protection-report] [skyline])
Attachments
(2 files)
Screenshot of patch
Create and implement designs for dark mode for about:protections.
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/13bb9ba5f69b Make about:protections support dark mode. r=ewright,johannh
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
I requested a backout as mtigley added some comments I haven't addressed: https://hg.mozilla.org/integration/autoland/rev/4c2aaf3c3d25
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bbde5a300f43 Make about:protections support dark mode. r=ewright,mtigley,johannh
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe65e1f85f74 Run ./mach eslint on protections JS files to fix lint errors. r=eslint-fix CLOSED TREE
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bbde5a300f43
https://hg.mozilla.org/mozilla-central/rev/fe65e1f85f74
|
||
Comment 9•5 years ago
|
||
The changes for the Monitor card's font-sizes seemed to be reverted after the push. This was the original diff with the correct changes: https://phabricator.services.mozilla.com/D38210?id=135958
|
|
Assignee | |
Comment 10•5 years ago
|
||
(In reply to Micah Tigley [:mtigley] from comment #9)
The changes for the Monitor card's font-sizes seemed to be reverted after the push. This was the original diff with the correct changes: https://phabricator.services.mozilla.com/D38210?id=135958
Ah, thanks for noticing that. This is pretty strange since Lando mentioned diff 135965 was landed and the latest diff on phabricator is Diff 135958.
Description
•