1562021 - [webvtt] cues are incorrectly displayed twice

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu][PTO until 12/16]]

Forked from bug 1535005 comment 6, the cues in English track were incorrectly displayed twice, but cues in other tracks won't have this issue.

Comment 1

[Alastor Wu [:alwu][PTO until 12/16]]

Attachment: Bug 1562021 - part1 : modify debug log for WebVTTListener.

Refactor these log by using the WebVTT log module and adding address info in the log.

Comment 2

[Alastor Wu [:alwu][PTO until 12/16]]

Attachment: Bug 1562021 - part2 : using same log module as other VTT related files.

This log module should be merged into a part of WebVTT log module because it's useless to check this log module independently.

Comment 3

[Alastor Wu [:alwu][PTO until 12/16]]

Attachment: Bug 1562021 - part3 : cancel old VTT listener when we start a new load.

When we start a new load, all previous data fetching from the previous listener and all state changing applied to track element should be ignored.

Therefore, we add a new method Cancel() which owner of the listener should call when we would like to discard current listener.

Comment 4

[Alastor Wu [:alwu][PTO until 12/16]]

Attachment: Bug 1562021 - part4 : wrap channel and listener clean-up to a function.

There are several places doing channel or listenr clean up, all these places should do channel and listener clean-up together because they are used as a pair.

Comment 5

[Alastor Wu [:alwu][PTO until 12/16]]

Attachment: Bug 1562021 - part5 : add test 'test_texttrack_mode_change_during_loading.html'.

In order to simulate the specific running order, we have to add a test event 'mozStartedLoadingTextTrack', which would be controlled under a pref.

This test is used to ensure that we won't get error event when we change track's mode during loading.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/602865e4e969
part1 : modify debug log for WebVTTListener. r=jya
https://hg.mozilla.org/integration/autoland/rev/da1f4f3f0c5c
part2 : using same log module as other VTT related files. r=jya
https://hg.mozilla.org/integration/autoland/rev/4fa9eb527c78
part3 : cancel old VTT listener when we start a new load. r=jya,baku
https://hg.mozilla.org/integration/autoland/rev/1ff85088fbf4
part4 : wrap channel and listener clean-up to a function. r=jya
https://hg.mozilla.org/integration/autoland/rev/084252265e0c
part5 : add test 'test_texttrack_mode_change_during_loading.html'. r=jya

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/602865e4e969
https://hg.mozilla.org/mozilla-central/rev/da1f4f3f0c5c
https://hg.mozilla.org/mozilla-central/rev/4fa9eb527c78
https://hg.mozilla.org/mozilla-central/rev/1ff85088fbf4
https://hg.mozilla.org/mozilla-central/rev/084252265e0c