1562166 - The "CFR FxA Bookmark Panel Message" is not correctly adjusted on the Firefox "ru" locale

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 68.0b14, Build ID 20190627143605
• Firefox Nightly 69.0a1, Build ID 20190627214735

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the latest Firefox Beta 68.0b14 "ru" locale build installed.
• Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to any website and click the "Bookmark this page" button from the right part of the "Address Bar".
3. Observe the "CFR FxA Bookmark Panel Message".

[Expected result]:

• The message is correctly displayed and rendered.

[Actual result]:

• The message is not correctly adjusted.

[Notes]:

• Attached a screen recording of the issue.

Comment 1

[Julien Cristau [:jcristau]]

I guess this is basically bug 1548784?

Comment 2

[Andrei Oprea [:andreio]]

That's right the height of the panel causes this issue.
Last time we discussed bug 1548784 it wasn't obvious if we can actually make the height fluid because of the animation used to show the message (in more detail: there is a fixed height container that either shows the purple message or a screenshot of the page being bookmarked. There is a animation where the purple message slides over the screenshot. The fixed height is required in order to keep things from moving up/down).

We might keep both bugs open, fix this one by working around the issue: smaller font size, smaller margins.

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-07-02 at 14.39.23.png

margin values adjusted, "ru" preview.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-07-02 at 14.39.30.png

margin values adjusted, "en-US" preview

Comment 5

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: this feature looks pretty terrible in Russian.

:mcoman, have you tested other locales and/or have you found any other issues?

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

Hi Tim, I have tested this issue on multiple Firefox locales, especially on the ones with long text strings (e.g. it, de) and with non-Latin characters (e.g. el, uk, zh-CN), but I have not managed to reproduce it. For now, the only affected build that I've found is the "ru" locale.

Comment 7

[Julien Cristau [:jcristau]]

If this really only affects Russian I wonder if the "exclude RU through remote targeting" option is the way to go for 68, vs crash-landing a fix straight to mozilla-release. wdyt?

Comment 8

[Tim Spurway [:tspurway]]

That sounds like a plan, Julien. We will make the change to disable RU remotely, but leave this bug open to track the fix for 69

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified and I can confirm that the "Sync to CTA when Bookmarking" message is no longer displayed on the Firefox "ru" locale. Verified on Windows 10 x64, Mac 10.14.5 and Arch Linux using latest Firefox Nightly "ru" locale (69.0a1 - Build ID: 20190704094530).

Comment 10

[Tim Spurway [:tspurway]]

fixed by bug #1548784

Comment 11

[Andrei Oprea [:andreio]]

Fixed by bug 1548784 with a solution that works for any locale with longer strings.