Closed Bug 1562295 Opened 5 years ago Closed 3 years ago

Don't create ClientLayerManager instances for tooltip windows

Categories

(Core :: Graphics: WebRender, task, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1722258

People

(Reporter: kats, Unassigned)

References

(Blocks 1 open bug)

Details

On Linux with WR enabled (via MOZ_ACCELERATED=1 MOZ_WEBRENDER=1) we create ClientLayerManager instances for tooltip widgets. This seems heavyweight, we should be creating BasicLayerManager instead.

At https://searchfox.org/mozilla-central/rev/867cbb1a2b232398616e1aa42f913f37c6cb38e4/widget/nsBaseWidget.cpp#1275 UseWebRender() is false, which is fine, but then it just goes into creating ClientLayerManager. Instead it should probably be checking for WidgetTypeSupportsAcceleration() before doing that.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.