Create a WindowRenderer implementation that uses layerless painting
Categories
(Core :: Web Painting, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
We still have a few uses of BasicLayerManager/FrameLayerBuilder (even when WR is enabled) for widgets that want a super lightweight in-thread rendering.
We can rasterize a display list directly now, so we should add a new WindowRenderer (formerly LayerManager) implementation for widgets to hold that just runs this without any retaining/invalidation.
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
Depends on D120919
|
|
Assignee | |
Comment 3•3 months ago
|
||
Depends on D120920
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4149d596d03d Split out fallible composite-only path of PresShell::Paint. r=miko https://hg.mozilla.org/integration/autoland/rev/41176d476eb7 Convert more LayerManager usage to use WindowRenderer. r=miko https://hg.mozilla.org/integration/autoland/rev/cf8a1175abd1 Add FallbackRenderer to replace BasicLayerManager usage. r=miko
|
||
Comment 5•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4149d596d03d
https://hg.mozilla.org/mozilla-central/rev/41176d476eb7
https://hg.mozilla.org/mozilla-central/rev/cf8a1175abd1
|
||
Comment 6•3 months ago
|
||
Backed out for causing Bug 1722935
backout: https://hg.mozilla.org/mozilla-central/rev/bdf05015fbffef15464dcad0cb7e5f0f7d309ebd
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce8f605d6920 Split out fallible composite-only path of PresShell::Paint. r=miko https://hg.mozilla.org/integration/autoland/rev/e8299f044303 Convert more LayerManager usage to use WindowRenderer. r=miko https://hg.mozilla.org/integration/autoland/rev/e505fffd43c3 Add FallbackRenderer to replace BasicLayerManager usage. r=miko
|
|
Assignee | |
Updated•3 months ago
|
|
||
Comment 8•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ce8f605d6920
https://hg.mozilla.org/mozilla-central/rev/e8299f044303
https://hg.mozilla.org/mozilla-central/rev/e505fffd43c3
|
||
Comment 9•2 months ago
•
|
||
Hi Matt, given the number of regressions already reported from this change and the incoming reports we're still getting, what do you think about backing this out from Beta92 so it has more Nightly bake time first? I've confirmed that it reverts cleanly.
|
|
Assignee | |
Comment 10•2 months ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
Hi Matt, given the number of regressions already reported from this change and the incoming reports we're still getting, what do you think about backing this out from Beta92 so it has more Nightly bake time first? I've confirmed that it reverts cleanly.
It's a tough call! We're hoping to remove a lot of the Layers code from Nightly93, so any regressions after that won't have a fallback option.
I think I'd prefer to try uplift the fix (up for review now, need to confirm that it's the same for all the regressions) if possible, since it's early in the beta cycle.
Description
•