1562306 - Update the strings of animation warnings for transform-like properties

Status: NEW

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Boris Chiou [:boris]]

We still use transform property in animation warning strings [1], but it's not correct because it may be caused by other transform-like properties, so we should replace "Animations of ‘transform’" with "Transform-related animations" or even just "Transform animations".

[1] https://searchfox.org/mozilla-central/rev/867cbb1a2b232398616e1aa42f913f37c6cb38e4/dom/locales/en-US/chrome/layout/layout_errors.properties#35-38

Comment 1

[Hiroyuki Ikezoe (:hiro)]

IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Anyways, if we change the strings we also need to change the symbols (i.e. CompositorAnimationWarningTransformSVG), IIRC.

Comment 3

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)

IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?

Yes, but Brian suggested it'd be better to use a more precise word to express this when reviewing the patches, so I filed this bug. Either way is ok to me actually.

Comment 4

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)

IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?

I checked the implementation again and we use transform property set for these warnings in most cases, so it becomes pretty hard to set the warning for a specific property name. For example, it might be a combination of part of transform-like properties, so we should use a general word for them. After introducing motion-path, we probably need to update the string to something like "transform or motion" properties. So for now, I prefer to not updating the string and not blocking ship bug.