1562359 - Assertion failure: cachedStyles[i]->EqualForCachedAnonymousContentStyle(*cs) (cached anonymous content styles should be identical to those we would compute normally), at /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:3962

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

layout/forms/crashtests/1212688.html | causes this assertion. (I saw this on a try of mine)

Just in case you are not aware of this.

Comment 1

[Cameron McCormack (:heycam)]

Thanks, I didn't see that failure before.

I'm going to turn the pref off so I can investigate this and bug 1562361 next week.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

layout/forms/crashtests/1212688.html | causes this assertion. (I saw this on a try of mine)

I did put a wrong link. Here is a failure on m-c that I wanted to put. https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=900a0b1270437d60f87cd2832743439824ee9473&selectedJob=254027747

Comment 3

[Cameron McCormack (:heycam)]

Thank you. Looks like it has been mis-starred.

Comment 4

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f7d16a1647624add0774c8791f893c418376c1

Comment 5

[Cameron McCormack (:heycam)]

From the logs:

Actual style:
  Properties:
    display: none
  Rules:
    xul|scrollbarbutton[sbattr="scrollbar-up-top"], xul|scrollbarbutton[sbattr="scrollbar-bottom-top"] { display: none; }
    xul|scrollbarbutton { background-image: none !important; }
    xul|scrollbarbutton { min-height: 6px !important; min-width: 6px !important; -moz-appearance: none !important; visibility: hidden; }
    scrollbar, scrollbarbutton, scrollcorner, slider, thumb { user-select: none; }
    scrollbarbutton, slider, thumb { direction: inherit; cursor: inherit; }
    scrollcorner, resizer, scrollbar, scrollbarbutton, slider { border-block: initial; border-inline: initial; border-start-start-radius: initial; border-start-end-radius: initial; border-end-start-radius: initial; border-end-end-radius: initial; overflow-inline: initial; overflow-block: initial; margin-block: initial; margin-inline: initial; scroll-margin-block: initial; scroll-margin-inline: initial; padding-block: initial; padding-inline: initial; scroll-padding-block: initial; scroll-padding-inline: initial; inset-block: initial; inset-inline: initial; block-size: initial; min-block-size: initial; max-block-size: initial; inline-size: initial; min-inline-size: initial; max-inline-size: initial; background: initial; background-blend-mode: initial; border: initial; border-radius: initial; box-decoration-break: initial; -moz-float-edge: initial; position: initial; float: initial; clear: initial; vertical-align: initial; overflow: initial; overflow-anchor: initial; transition: initial; animation: initial; tr
    * { -moz-user-focus: ignore; user-select: none; display: -moz-box; box-sizing: border-box; }
Expected style:
  Properties:
    display: block
  Rules:
    select:not([size]):not([multiple]) > xul|scrollbar, select[size="1"] > xul|scrollbar, select:not([size]):not([multiple]) xul|scrollbarbutton, select[size="1"] xul|scrollbarbutton { display: block; margin-left: 0px; min-width: 16px; }
    xul|scrollbarbutton[sbattr="scrollbar-up-top"], xul|scrollbarbutton[sbattr="scrollbar-bottom-top"] { display: none; }
    xul|scrollbarbutton { background-image: none !important; }
    xul|scrollbarbutton { min-height: 6px !important; min-width: 6px !important; -moz-appearance: none !important; visibility: hidden; }
    scrollbar, scrollbarbutton, scrollcorner, slider, thumb { user-select: none; }
    scrollbarbutton, slider, thumb { direction: inherit; cursor: inherit; }
    scrollcorner, resizer, scrollbar, scrollbarbutton, slider { border-block: initial; border-inline: initial; border-start-start-radius: initial; border-start-end-radius: initial; border-end-start-radius: initial; border-end-end-radius: initial; overflow-inline: initial; overflow-block: initial; margin-block: initial; margin-inline: initial; scroll-margin-block: initial; scroll-margin-inline: initial; padding-block: initial; padding-inline: initial; scroll-padding-block: initial; scroll-padding-inline: initial; inset-block: initial; inset-inline: initial; block-size: initial; min-block-size: initial; max-block-size: initial; inline-size: initial; min-inline-size: initial; max-inline-size: initial; background: initial; background-blend-mode: initial; border: initial; border-radius: initial; box-decoration-break: initial; -moz-float-edge: initial; position: initial; float: initial; clear: initial; vertical-align: initial; overflow: initial; overflow-anchor: initial; transition: initial; animation: initial; tr
    * { -moz-user-focus: ignore; user-select: none; display: -moz-box; box-sizing: border-box; }
Assertion failure: cachedStyles[i]->EqualForCachedAnonymousContentStyle(*cs) (cached anonymous content styles should be identical to those we would compute normally), at /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:3962

Comment 6

[Cameron McCormack (:heycam)]

So https://searchfox.org/mozilla-central/rev/867cbb1a2b232398616e1aa42f913f37c6cb38e4/layout/generic/nsGfxScrollFrame.cpp#4980-4986 is not doing its job.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

I haven't debugged it, so I am probably wrong, but normally mOuter is the scrollable frame, so we should use mScrolledFrame instead? (I don't actually know what mOuter's nsIContent is there)

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d6f7d16a1647

Comment 9

[Cameron McCormack (:heycam)]

Ah I think it's failing in this test because the markup is

<style>
  optgroup { overflow-x: hidden; }
</style>
<select>
  <optgroup>
    <option>

and in mobile/android/themes/geckoview/content.css we have

select:not([size]):not([multiple]) > xul|scrollbar,
select[size="1"] > xul|scrollbar,
select:not([size]):not([multiple]) xul|scrollbarbutton,
select[size="1"] xul|scrollbarbutton {
  display: block;
  margin-left: 0;
  min-width: 16px;
}

and note that these have descendant selectors to match the scrollbarbutton elements. I think the optgroup is making its own scrollbars, separate from the select's. And the check I linked to in comment 6 would find that the parent of that scrollbar element is the optgroup.

I think we can just adjust the UA style rule to use child selectors instead. (We don't actually do anything with these optgroup scrollbars.)

Comment 10

[Cameron McCormack (:heycam)]

And I don't think we even use XUL select popups on GeckoView, so I'm not sure why we have these rules.

Comment 11

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=929d0763d0a04526a6970ce0f96cf10b46434d4e

Comment 12

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aab9a0bbdab6a9173c4ff461e0743c413fd21474

Comment 13

[Cameron McCormack (:heycam)]

Attachment: Bug 1562359 - Tweak XUL scrollbar styles on GeckoView to avoid cached scrollbar style assertions.

Comment 14

[Intermittent Failures Robot]

1 failures in 4409 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• android-em-4-3-armv7-api16: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1562359&startday=2019-06-24&endday=2019-06-30&tree=all

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/529c44a1eba8
Tweak XUL scrollbar styles on GeckoView to avoid cached scrollbar style assertions. r=emilio

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/529c44a1eba8

Comment 17

[Intermittent Failures Robot]

8 failures in 4710 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8

Platform breakdown:

• windows10-64: 2
• linux64: 1
• linux64-qr: 1
• windows7-32: 3
• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1562359&startday=2019-07-08&endday=2019-07-14&tree=all

Comment 18

[Emilio Cobos Álvarez [:emilio]]

should this bug be closed?

Comment 19

[Cameron McCormack (:heycam)]

Thanks, yes.