1563699 - 7.96% perf_reftest_singletons (linux64-shippable-qr) regression on push d6f7d16a1647624add0774c8791f893c418376c1 (Sat June 29 2019)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Florin Strugariu [:Bebe]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=d6f7d16a1647624add0774c8791f893c418376c1

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

8% perf_reftest_singletons linux64-shippable-qr opt e10s stylo 46.42 -> 50.12

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21723

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I'll let cam confirm, but I think this is expected and should've gone back to normal where the feature was re-enabled in bug 1562361. Mind confirming it Florin? Thanks!

Comment 2

[Florin Strugariu [:Bebe]]

Emilio you are correct. The regression was fixed in alert: https://treeherder.mozilla.org/perf.html#/alerts?id=21712

== Change summary for alert #21712 (as of Tue, 02 Jul 2019 16:36:49 GMT) ==

Improvements:

5% perf_reftest_singletons linux64-shippable opt e10s stylo 48.25 -> 45.80
5% perf_reftest_singletons linux64-shippable-qr opt e10s stylo 50.01 -> 47.47

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21712

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Alright, thanks for confirming!