Closed Bug 1562503 Opened 5 years ago Closed 5 years ago

Use nsPresShell::IsRootContentDocumentCrossProcess to tell whether we need to create MobileViewportManager or ZoomConstraintsClient

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.

I have an idea to write mochitest for this.

Assignee: nobody → hikezoe
Status: NEW → ASSIGNED

browserElement_ScrollEvent.js is affected by this change. Before this change
the document for iframe mozbrowser was not considered as the root content
document, but after this change, it's considered as the root content document.
Given the nature of iframe mozbrowser, I believe it's the right behavior.

The browser mochitest in this commit fails without this change since
the minimum-scale size is used in the out-of-process iframe so that the visual
viewport size gets 3x bigger than the expected size.

Blocks: 1553013

We should also check IsRootContentDocumentCrossProcess instead of
IsRootContentDocument there, it will be fixed in bug 1562505.

The test case in this commit is almost copied-n-pasted from
helper_scroll_into_view_bug1516056.html.

Attachment #9075283 - Attachment description: Bug 1562503 - Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r?botond → Bug 1562757 - Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r?botond

Comment on attachment 9075283 [details]
Bug 1562757 - Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r?botond

Revision D36556 was moved to bug 1562757. Setting attachment 9075283 [details] to obsolete.

Attachment #9075283 - Attachment is obsolete: true
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/758f027a054f
Create GeckoMVMContext and ZoomConstraintsClient only for the root top level document. r=botond
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: