1562503 - Use nsPresShell::IsRootContentDocumentCrossProcess to tell whether we need to create MobileViewportManager or ZoomConstraintsClient

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I have an idea to write mochitest for this.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68313779ca54ddf9a3b70b279cda638af3325d1b

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1562503 - Create GeckoMVMContext and ZoomConstraintsClient only for the root top level document. r?botond

browserElement_ScrollEvent.js is affected by this change. Before this change
the document for iframe mozbrowser was not considered as the root content
document, but after this change, it's considered as the root content document.
Given the nature of iframe mozbrowser, I believe it's the right behavior.

The browser mochitest in this commit fails without this change since
the minimum-scale size is used in the out-of-process iframe so that the visual
viewport size gets 3x bigger than the expected size.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1562757 - Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r?botond

We should also check IsRootContentDocumentCrossProcess instead of
IsRootContentDocument there, it will be fixed in bug 1562505.

The test case in this commit is almost copied-n-pasted from
helper_scroll_into_view_bug1516056.html.

Comment 5

[Phabricator Automation]

Comment on attachment 9075283 [details]
Bug 1562757 - Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r?botond

Revision D36556 was moved to bug 1562757. Setting attachment 9075283 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/758f027a054f
Create GeckoMVMContext and ZoomConstraintsClient only for the root top level document. r=botond

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/758f027a054f