1562621 - Reverting changes on beta/release/esr should not reopen revisions

Status: NEW

(Conduit :: Phabricator, defect, P3)

Description

[:Gijs (he/him)]

https://phabricator.services.mozilla.com/D24445 and https://phabricator.services.mozilla.com/D23147 were reopened when they were backed out on release/esr68 in bug 1557256. This shouldn't have happened because the changes are still there on central/nightly.

Comment 2

[:glob ✱]

What's happening is we have two separate commits both referring back to the same Phabricator revision (via the Differential Revision line in the commit description). Phabricator cannot tell the difference between actions performed on different "branches" with how Mozilla's repositories and uplifts work.

The longer term solution for this, which has been under discussion for some time with Release Management, is to require separate revisions for each of the "branches". Part of this work involves automation to reduce the overhead of creating uplift revisions.

For now this issue can be avoided if the commit description is amended during the uplift process to remove the Differential Revision line.

We'll do some investigation here to determine how viable that work around is.

Comment 3

[:glob ✱]

The current goal is to make uplift requests an explicit moz-phab action, which will create a new phabricator revision for tracking the uplift on each branch.