1737838 - Add a `moz-phab uplift` command

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P2)

Description

[Connor Sheehan [:sheehan]]

Request a local revision be posted to Phabricator as an uplift.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: requirements: add debugpy to requirements (Bug 1737838) r?zeid

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: license: add license to test_submit.py (Bug 1737838) r?zeid

We should have the MPL at the top of all files that can
support the license.

Depends on D131981

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: vcs: remove call to super().refresh_commit_stack() since its an empty function (Bug 1737838) r?zeid

Depends on D131982

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: uplifts: add a `moz-phab` uplift command (Bug 1737838) r?zeid

Add a moz-phab uplift command to send commits to Phabricator
to be reviewed as uplift requests. The interface is similar to
moz-phab submit, in that a revset/commit range is specified
for submission, but the user must also pass a --train argument
with a Phabricator callsign indicating the target uplift train
to submit to. The target repos are any repository on Phabricator
with an uplift project tag associated with the repository. If the
repository has an appropriate named tag/bookmark/branch associated
with the passed train, a new set of revisions will be created via
rebase and the new commits will be submitted for uplift. When amending
the commits, the Differential Revision of the original revision
is moved to Original Revision and the uplift revision is set as
the Differential Revision.

To keep uplifting behaviour consistent with regular submissions the
uplift command re-uses almost all of the logic of submit, with
a few amendments that check the value of args.command to determine
if the uplift specific code paths should be taken. The submit
CLI argument parser is turned into a function so it can be re-used
by the submit parser.

A conduit function call is added to return repositories with an
associated tag, in our case the uplift tag. We add a few VCS specific
functions to associate a callsign with a named branch/symbol and to
perform the automatic uplifting functionality.

TODOS
- no telemetry
- if rebase fails we continue and submit anyways, probably wrong
- needs unit tests

Depends on D131983

Comment 5

[Connor Sheehan [:sheehan]]

This has landed in the repo, and we'll track getting it out to users in bug 1754057.