1562704 - Fix text-underline-offset for japanese text

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Charlie Marlow [:cmarlow]]

As shown in test case below, Japanese text-underlines do not respond to text-underline-offset

Comment 1

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1562704: fixed text-underline-offset for Japanese and Korean text, where underlines appear to the right of text r?jfkthame

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b67dff062c6
fixed text-underline-offset for Japanese and Korean text, where underlines appear to the right of text r=jfkthame

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1561657, Bug 1557857, Bug 1562704) for causing Wr permafailures in z:/build/build/src/layout/base/nsCSSFrameConstructor.cpp:3962 CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=fb8fbe6000f3ae72051a961f880f4a54299bf885&selectedJob=255307738

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255307738&repo=autoland&lineNumber=32915

Comment 4

[Daniel Holbert [:dholbert]]

I think bug 1557857 is the problematic commit - that's the one that introduces the test that has failures. So, I'm relanding the patch for this bug here (without bug 1557857).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2db5b50efcc3
fixed text-underline-offset for Japanese and Korean text, where underlines appear to the right of text r=jfkthame

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2db5b50efcc3