Closed Bug 1562944 Opened 5 years ago Closed 2 years ago

Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools

Categories

(Core :: Gecko Profiler, defect, P3)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Depends on 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression)

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=254403205&repo=mozilla-inbound
Full log: https://queue.taskcluster.net/v1/task/TS_w_qEGRtymafXycjjkJg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/TS_w_qEGRtymafXycjjkJg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

11:14:19 INFO - TEST-PASS | tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the parent processes' main thread when JS allocation was not turned on. - 0 == 0 -
11:14:19 INFO - Buffered messages finished
11:14:19 INFO - TEST-UNEXPECTED-FAIL | tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_jsallocations.js :: test_profile_feature_jsallocations/< :: line 56
11:14:19 INFO - Stack trace:
11:14:19 INFO - chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_jsallocations.js:test_profile_feature_jsallocations/<:56
11:14:19 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
11:14:19 INFO - chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_jsallocations.js:test_profile_feature_jsallocations:19
11:14:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
11:14:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
11:14:19 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
11:14:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
11:14:19 INFO - GECKO(10228) | [Parent 7232, Main Thread] WARNING: Constructing RangeBoundary with invalid value: 'mRef || aOffset == 0', file z:/build/build/src/obj-firefox/dist/include\mozilla/RangeBoundary.h, line 79
11:14:19 INFO - GECKO(10228) | [Parent 7232, Main Thread] WARNING: Constructing RangeBoundary with invalid value: 'mRef || aOffset == 0', file z:/build/build/src/obj-firefox/dist/include\mozilla/RangeBoundary.h, line 79
11:14:19 INFO - GECKO(10228) | [Child 5920, Main Thread] WARNING: No active window: file z:/build/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
11:14:19 INFO - Leaving test bound test_profile_feature_jsallocations
11:14:19 INFO - GECKO(10228) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 110: uncaught exception: Object
11:14:19 INFO - GECKO(10228) | MEMORY STAT | vsize 2104297MB | vsizeMaxContiguous 65090438MB | residentFast 386MB | heapAllocated 104MB

Yours, Greg?

Type: -- → defect
Flags: needinfo?(gtatum)
Priority: P5 → P2
Regressed by: 1545582
Assignee: nobody → gtatum
Flags: needinfo?(gtatum)

This is most likely due to RacyRegisteredThread::mPendingMarkers retaining some errant markers in the thread.

After talking to gerald, this problem will go away with Bug 1562604. I'm going to opt to create a solution in the test itself. I can do some hacky things with JS to ensure we clear them out, and encapsulate it in a function in the test's head.js. I can then file a follow-up once I implement a solution and make it depend on Bug 1562604.

I believe this was resolved by Bug 1564150.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Wait, maybe not. There were still a few intermittents after when the bug landed. I was confused by the orange factor graph.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: gtatum → nobody
Priority: P2 → P4

I'm un-assigning myself and de-prioritizing this as Bug 1564150 lowered the failure rate.

Started appearing on tier 1 jobs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272751012&repo=autoland&lineNumber=8606

Summary: Intermittent TV tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools → Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools
Summary: Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools → Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was [not] turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools
See Also: → 1636556

I'm reverting the title change, I think we should keep this bug separate from bug 1636556, even though they happen in the same file (see-also can stay) :

  • In bug 1636556 we have no allocation markers when we expected some. This looks like a buffer size issue, which I will fix in related bug 1636398.
  • Here, we have allocation markers when they were not expected. A too-small buffer cannot explain that, I will need to investigate further...
Priority: P4 → P3
Summary: Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was [not] turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools → Intermittent tools/profiler/tests/browser/browser_test_feature_jsallocations.js | No allocations were recorded for the content processes' main thread when JS allocation was not turned on. - 1 == 0 - JS frame :: chrome://mochitests/content/browser/tools
Has Regression Range: --- → yes
Severity: normal normal → S3 S3

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.