1562996 - make a GeneratedFile template instead of all the boilerplate around GENERATED_FILES

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Nathan Froyd [:froydnj]]

GENERATED_FILES requires a fair amount of boilerplate:

https://searchfox.org/mozilla-central/source/config/moz.build#59-64
https://searchfox.org/mozilla-central/source/js/src/build/moz.build#32-37

Maybe it would be nicer to have an @template like:

GeneratedFile(name, script, entry_point="main", flags, ...other arguments...)

and people could just use keyword arguments, and the template would handle a bunch of stuff behind the scenes? Would also be nice for getting rid of the "script.py:entry_point" convention, which shouldn't really be exposed to the user.

The larger thing to explore here is moving moz.build files to mostly @template invocations, which would be more compatible with a Starlark-like language.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Here's a decent example of how a template might achieve this: https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/build/test_templates.mozbuild#8

Comment 2

[Ricky Stewart]

Attachment: Bug 1562996 - Add a GeneratedFile template to get rid of some of the boilerplate involved in interfacing with GENERATED_FILES.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0015a8868e7aefab1f987156cab0c80d0c00b85b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/134999fb1885
Add a GeneratedFile template to get rid of some of the boilerplate involved in interfacing with GENERATED_FILES. r=nalexander

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/134999fb1885