1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Ricky Stewart]

Attachment: Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d95f2c8867b
Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander

Comment 3

[Daniel Varga [:dvarga]]

Backed out changeset 8d95f2c8867b (Bug 1586358) for build bustage with FATAL ERROR PROCESSING MOZBUILD FILE.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8d95f2c8867b13432cf2e0c51c7765e6592441ea

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270093726&repo=autoland&lineNumber=1412

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=270104133&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b121d61e533a61c777fe7d6ca80f4858d9d148ee

[task 2019-10-07T17:01:57.153Z] 17:01:57     INFO -  Reticulating splines...
[task 2019-10-07T17:01:57.155Z] 17:01:57    ERROR -  Traceback (most recent call last):
[task 2019-10-07T17:01:57.155Z] 17:01:57     INFO -    File "z:/build/build/src/configure.py", line 164, in <module>
[task 2019-10-07T17:01:57.155Z] 17:01:57     INFO -      sys.exit(main(sys.argv))
[task 2019-10-07T17:01:57.157Z] 17:01:57     INFO -    File "z:/build/build/src/configure.py", line 45, in main
[task 2019-10-07T17:01:57.158Z] 17:01:57     INFO -      return config_status(config)
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -    File "z:/build/build/src/configure.py", line 159, in config_status
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -      return config_status(args=[], **normalize(sanitized_config))
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -    File "z:\build\build\src\python\mozbuild\mozbuild\config_status.py", line 142, in config_status
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -      definitions = list(definitions)
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -    File "z:\build\build\src\python\mozbuild\mozbuild\frontend\emitter.py", line 170, in emit
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -      for out in output:
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -    File "z:\build\build\src\python\mozbuild\mozbuild\frontend\reader.py", line 883, in read_topsrcdir
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -      for r in self.read_mozbuild(path, self.config):
[task 2019-10-07T17:01:57.159Z] 17:01:57     INFO -    File "z:\build\build\src\python\mozbuild\mozbuild\frontend\reader.py", line 1050, in read_mozbuild
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -      raise bre
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  mozbuild.frontend.reader.BuildReaderError:
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  ==============================
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  ==============================
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  The error occurred while processing the following file:
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -      z:/build/build/src/config/external/icu/data/moz.build
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  The error was triggered on line 28 of this file:
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -      SOURCES += ['!%s' % icudata]
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
[task 2019-10-07T17:01:57.160Z] 17:01:57     INFO -  The error as reported by Python is:
[task 2019-10-07T17:01:57.161Z] 17:01:57    ERROR -      ["NameError: name 'icudata' is not defined\n"]
[task 2019-10-07T17:01:57.200Z] 17:01:57     INFO -  *** Fix above errors and then restart with\
[task 2019-10-07T17:01:57.200Z] 17:01:57     INFO -                 "./mach build"
[task 2019-10-07T17:01:57.200Z] 17:01:57     INFO -  client.mk:111: recipe for target 'configure' failed
[task 2019-10-07T17:01:57.200Z] 17:01:57     INFO -  mozmake.EXE: *** [configure] Error 1
[task 2019-10-07T17:05:02.307Z] WARNING | IO Completion Port failed to signal process shutdown
[task 2019-10-07T17:05:02.307Z] Parent process 3136 exited with children alive:
[task 2019-10-07T17:05:02.307Z] PIDS: 3844
[task 2019-10-07T17:05:02.307Z] Attempting to kill them, but no guarantee of success
[task 2019-10-07T17:05:02.307Z] 17:05:02    ERROR - Return code: 2
[task 2019-10-07T17:05:02.307Z] 17:05:02  WARNING - setting return code to 2
[task 2019-10-07T17:05:02.307Z] 17:05:02    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2019-10-07T17:05:02.307Z] 17:05:02    FATAL - Running post_fatal callback...
[task 2019-10-07T17:05:02.307Z] 17:05:02    FATAL - Exiting -1
[task 2019-10-07T17:05:02.307Z] 17:05:02     INFO - [mozharness: 2019-10-07 17:05:02.307000Z] Finished build step (failed)
[task 2019-10-07T17:05:02.307Z] 17:05:02     INFO - Running post-run listener: _parse_build_tests_ccov

Comment 4

[Ricky Stewart]

Attachment: Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template

Comment 5

[Ricky Stewart]

Missed a file that didn't come up in any of the builds I ran for my try push -- the new patch should fix it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb7912816d3e
Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fb7912816d3e