Closed Bug 1563021 Opened 5 months ago Closed 2 months ago

Add Private Browsing Search Engine onto the Preferences display

Categories

(Firefox :: Search, task, P2)

task
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox71 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of implementing the private browsing search engine, we should add a UI for setting it.

The UI should be able to be hidden by the pref added in bug 1562922.

Assignee: nobody → standard8
Status: NEW → ASSIGNED

Comment on attachment 9094953 [details]
Bug 1563021 - Add preferences UI to allow enabling and selection of a separate default private engine.

Verdi, could you try these builds out please?

https://queue.taskcluster.net/v1/task/SwQeCiXvRvS62NnzSuWIDQ/runs/0/artifacts/public/build/target.dmg
https://queue.taskcluster.net/v1/task/VKJHBDRCTkWLI2vqEZt8vg/runs/0/artifacts/public/build/target.zip

Notes:

  • The preference display will just be re-arranged initially, you'll need to set the browser.search.separatePrivateDefault.enabled to true to see the separate search engine.
  • The sub-text is currently grey rather than black. That's the default theming for preferences for indented sections. Quite happy to change it if you want, but I left it as it was to being with.
  • Only the address bar, search bar and context menu pick up the changed default in private browsing at the moment - the new tab page does not.
  • The extra check box for show private search suggestions will be created in bug 1583162.
  • I've used the text that is in the design doc, I'm assuming you're signing off on that as well.
Attachment #9094953 - Flags: ui-review?(mverdi)

Comment on attachment 9094953 [details]
Bug 1563021 - Add preferences UI to allow enabling and selection of a separate default private engine.

Hi Mark. Mostly this is looking good. The main thing I see is that when I flip the pref, the "Use this search engine in Private Windows" checkbox is unchecked. It should be checked by default and it's unchecking it that reveals the dropdown to choose a PBM search engine. It seems like it's backward in this build. The other thing I notice that you didn't mention above is that there isn't a link back to the history settings in Privacy & Security. That should be below the search suggestions section.

Attachment #9094953 - Flags: ui-review?(mverdi) → ui-review-

I also want to note that I can see how you saw that this pref would work differently that what I intended. I think I can fix that with copy. I will bring this up specifically with Betsy.

Blocks: 1576160
Attachment #9094953 - Flags: ui-review- → ui-review?(mverdi)
Iteration: --- → 71.2 - Sept 16 - 29

Comment on attachment 9094953 [details]
Bug 1563021 - Add preferences UI to allow enabling and selection of a separate default private engine.

This looks right. Let's go ahead and change that gray sub-text to black though.

Attachment #9094953 - Flags: ui-review?(mverdi) → ui-review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d973794f0e0
Add preferences UI to allow enabling and selection of a separate default private engine. r=fluent-reviewers,jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Flags: qe-verify+
QA Contact: pablo.muir
You need to log in before you can comment on or make changes to this bug.