1563182 - Add a js-format hg hook support by using an hg extension

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Victor Porof [:vporof][:vp]]

This hook will automatically format at the commit stage and update the content of the pending changes.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1563182 - hgext: Add js-format to the bootstrap process, r=andi

Depends on D33491

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1563182 - hgext: Add a new hg extension to run js-format at the commit step, r=andi

Depends on D36731

Comment 3

[Victor Porof [:vporof][:vp]]

How is stuff generally landed to the rVCT version-control-tools repo? Would checkin-needed work? This needs to be coordinated with the m-c landing, at the very least for https://bugzilla.mozilla.org/show_bug.cgi?id=1556393

Comment 4

[Connor Sheehan [:sheehan]]

(In reply to Victor Porof [:vporof][:vp] from comment #3)

How is stuff generally landed to the rVCT version-control-tools repo? Would checkin-needed work? This needs to be coordinated with the m-c landing, at the very least for https://bugzilla.mozilla.org/show_bug.cgi?id=1556393

We use Lando for landings. IIRC you can link differentials from separate repositories and land them all at once with Lando. However someone who has scm_versioncontrol will need to do the landing for version-control-tools.

As long as the changes in central have landed, we should be able to land the v-c-t changes at any time, right? We could link the central patches up to the base of a stack, and add the v-c-t patches on top, then someone with scm_level_3 can land the m-c stuff and myself/someone with scm_versioncontrol can land the second half of the stack to v-c-t.

Comment 5

[Victor Porof [:vporof][:vp]]

Yes, the m-c stuff needs to land first, and we've coordinated tree closures on July 5 to make that happen.

Because we don't want to break everyone's patches when reformatting the entire tree, landing bug 1556328 and bug 1556393 is crucial. This bug 1563182 is also nice to have.

I'll land the m-c patches during the tree closures, perhaps you can help out with landing the v-c-t patches immediately afterwards?

Comment 6

[Victor Porof [:vporof][:vp]]

Here's the v-c-t stack: https://lando.services.mozilla.com/D36732/

Comment 7

[Connor Sheehan [:sheehan]]

(In reply to Victor Porof [:vporof][:vp] from comment #5)

Yes, the m-c stuff needs to land first, and we've coordinated tree closures on July 5 to make that happen.

Because we don't want to break everyone's patches when reformatting the entire tree, landing bug 1556328 and bug 1556393 is crucial. This bug 1563182 is also nice to have.

I'll land the m-c patches during the tree closures, perhaps you can help out with landing the v-c-t patches immediately afterwards?

Certainly! What time do you plan to land? I'll be online 9am-5pm EST.

IIRC, for the last tree reformat, we only enabled format-source and we later wrote/enabled the clang-format extension to handle changes once format-source was disabled. That's the plan for this change as well, correct?

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Connor Sheehan [:sheehan] from comment #7)

(In reply to Victor Porof [:vporof][:vp] from comment #5)

Yes, the m-c stuff needs to land first, and we've coordinated tree closures on July 5 to make that happen.

Because we don't want to break everyone's patches when reformatting the entire tree, landing bug 1556328 and bug 1556393 is crucial. This bug 1563182 is also nice to have.

I'll land the m-c patches during the tree closures, perhaps you can help out with landing the v-c-t patches immediately afterwards?

Certainly! What time do you plan to land? I'll be online 9am-5pm EST.

IIRC, for the last tree reformat, we only enabled format-source and we later wrote/enabled the clang-format extension to handle changes once format-source was disabled. That's the plan for this change as well, correct?

I'm ok with any approach, but as far as I can tell there's no reason to have format-source disabled for js-format to be enabled. I'll ping you and let's coordinate on slack on July 5th.

Comment 9

[Victor Porof [:vporof][:vp]]

We should land this today.
Here's the stack: https://lando.services.mozilla.com/D36732/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/87bdc08bdd98
hgext: Add a new hg extension to run js-format at the commit step, r=andi
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ad487e509679
hgext: Add js-format to the bootstrap process, r=andi