1563324 - Small script cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1563324 - Remove use of FunctionBox::function() in ParseContext::init() r?jorendorff

Depends on D36813

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1563325 - Remove unnecessary LazyScript::function_ checks r?tcampbell

The field is not nullable

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2ba62a4f85
Bug 1563325 - Remove unnecessary LazyScript::function_ checks r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/68420d58de49
Remove use of FunctionBox::function() in ParseContext::init() r=jorendorff

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1563324 - Remove variable shadowing in emitFunction to ease readability r?khyperia

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1563324 - Clean up no longer applicable comment r?khyperia

Depends on D39016

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4c2ba62a4f85
https://hg.mozilla.org/mozilla-central/rev/68420d58de49

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a88be387be
Remove variable shadowing in emitFunction to ease readability r=khyperia
https://hg.mozilla.org/integration/autoland/rev/2bc72b6e4e9d
Clean up no longer applicable comment r=khyperia

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/90a88be387be
https://hg.mozilla.org/mozilla-central/rev/2bc72b6e4e9d

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?

Comment 10

[Matthew Gaudet (he/him) [:mgaudet]]

Yeah, why don't we just close this.