Closed Bug 1563325 Opened 7 months ago Closed 7 months ago

Disable login autocomplete for subdomains on non-Nightly

Categories

(Toolkit :: Password Manager, task, P1)

Desktop
All
task

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 --- unaffected
firefox69 --- verified

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 589628 introduced some regressions that we didn't have time to fix yet so let's keep the feature on Nightly for now.

Comment on attachment 9075764 [details]
Bug 1563325 - Remove unnecessary LazyScript::function_ checks r?tcampbell

Revision D36813 was moved to bug 1563324. Setting attachment 9075764 [details] to obsolete.

Attachment #9075764 - Attachment is obsolete: true
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/b367977ca698
Disable login autocomplete for subdomains on non-Nightly. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Hello Matthew,
Can you give me some pointers in how can I manually verify it?
Thank you!

Flags: needinfo?(MattN+bmo)

(In reply to Alexandru Trif, QA [:atrif] from comment #6)

Can you give me some pointers in how can I manually verify it?

Have logins saved for two subdomains and ensure they don't both show as suggestions on one of the sites when you're on non-Nightly.

Flags: needinfo?(MattN+bmo)
Flags: qe-verify+

Hello,
Using STR from comment 7 and Firefox 69.0b9 (20190730004747) on Windows 10x64 I checked that having 2 different loggings on two subdomains login pages (en.wikipedia.org and ro.wikipedia.org) they don't both show up as suggestions on one of the subdomains.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.