1563325 - Disable login autocomplete for subdomains on non-Nightly

Status: VERIFIED FIXED

(Toolkit :: Password Manager, task, P1)

Description

[Matthew N. [:MattN]]

Bug 589628 introduced some regressions that we didn't have time to fix yet so let's keep the feature on Nightly for now.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1563325 - Remove unnecessary LazyScript::function_ checks r?tcampbell

The field is not nullable

Comment 2

[Phabricator Automation]

Comment on attachment 9075764 [details]
Bug 1563325 - Remove unnecessary LazyScript::function_ checks r?tcampbell

Revision D36813 was moved to bug 1563324. Setting attachment 9075764 [details] to obsolete.

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1563325 - Disable login autocomplete for subdomains on non-Nightly. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b367977ca698
Disable login autocomplete for subdomains on non-Nightly. r=sfoster

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b367977ca698

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Hello Matthew,
Can you give me some pointers in how can I manually verify it?
Thank you!

Comment 7

[Matthew N. [:MattN]]

(In reply to Alexandru Trif, QA [:atrif] from comment #6)

Can you give me some pointers in how can I manually verify it?

Have logins saved for two subdomains and ensure they don't both show as suggestions on one of the sites when you're on non-Nightly.

Comment 8

[Alexandru Trif, Desktop QA [:atrif]]

Hello,
Using STR from comment 7 and Firefox 69.0b9 (20190730004747) on Windows 10x64 I checked that having 2 different loggings on two subdomains login pages (en.wikipedia.org and ro.wikipedia.org) they don't both show up as suggestions on one of the subdomains.