1563446 - Clean up MozAutocompleteRichlistitem fragment markup

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1557913 +++

Here:

https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/toolkit/content/widgets/autocomplete-richlistitem.js#93-117

... we can replace ></image> and ></description> with just />.

Comment 1

[ShubhamChinda]

Hey, Can I take up this issue?

Comment 2

[Dão Gottwald [:dao]]

(In reply to shubhamchinda07 from comment #1)

Hey, Can I take up this issue?

Sure. Do you have the source code already? Let me know if you have questions.

Comment 3

[ShubhamChinda]

No, I don't have the source code.

Comment 4

[Dão Gottwald [:dao]]

Here's a guide for getting the source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial

Here's a guide for building Firefox fast (this works because you won't need to modify C++ for this bug): https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds

And here's how you can put together a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 5

[ShubhamChinda]

Hey, I've committed the changes. Can you please review it?

Comment 6

[Dão Gottwald [:dao]]

(In reply to ShubhamChinda from comment #5)

Hey, I've committed the changes. Can you please review it?

I don't see your changes. You need to submit them to phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 7

[Dão Gottwald [:dao]]

Are you going to submit your patch for review?

Comment 8

[ShubhamChinda]

(In reply to Dão Gottwald [::dao] from comment #7)

Are you going to submit your patch for review?

Hey, I'm little trouble in setting up the phabricator. Give me 2 days, I'll figure it out submit the patch.

Comment 9

[ShubhamChinda]

having*(In reply to ShubhamChinda from comment #8)

(In reply to Dão Gottwald [::dao] from comment #7)

Are you going to submit your patch for review?

Hey, I'm little trouble in setting up the phabricator. Give me 2 days, I'll figure it out submit the patch.

Comment 10

[Chris Muldoon]

Hi can i take over this issue?

First time. I have got phabricator, mercurial and have built firefox, just a little unsure how to submit a patch for the first time is all

Comment 11

[Andrew Swan [:aswan]]

(In reply to Chris Muldoon from comment #10)

Hi can i take over this issue?

First time. I have got phabricator, mercurial and have built firefox, just a little unsure how to submit a patch for the first time is all

Sure, instructions for submitting your patch are here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 12

[Chris Muldoon]

Attachment: Bug 1563446 - Clean up MozautocompleteRichlistitem fragment markup

Comment 13

[Chris Muldoon]

I think this is ok? First time, so let me know of any noobie mistakes.

Comment 14

[ShubhamChinda]

(In reply to Chris Muldoon from comment #13)

I think this is ok? First time, so let me know of any noobie mistakes.

Hey, would you mind telling me how did you set up the phabricator?
Thanks :)

Comment 15

[Chris Muldoon]

Attachment: Bug 1563446 - Clean up MozAutocompleteRichlistitem

Depends on D38420

Comment 16

[Chris Muldoon]

Attachment: Bug 1563446 - Clean up MozautocompleteRichlistitem fragment markup

Depends on D38420

Comment 17

[Chris Muldoon]

Sorry about the mess, obviously i need to get my head around Mercurial a bit better :)

Comment 18

[Chris Muldoon]

Attachment: Bug 1563446 - Clean up MozAutocompleteRichListitem fragment markup

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/879f7007188e
Clean up MozAutocompleteRichListitem fragment markup r=dao

Comment 20

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/879f7007188e