Closed Bug 1563446 Opened 2 months ago Closed Last month

Clean up MozAutocompleteRichlistitem fragment markup

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: dao, Assigned: chris.muldoon90, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #1557913 +++

Here:

https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/toolkit/content/widgets/autocomplete-richlistitem.js#93-117

... we can replace ></image> and ></description> with just />.

Hey, Can I take up this issue?

(In reply to shubhamchinda07 from comment #1)

Hey, Can I take up this issue?

Sure. Do you have the source code already? Let me know if you have questions.

No, I don't have the source code.

Here's a guide for getting the source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial

Here's a guide for building Firefox fast (this works because you won't need to modify C++ for this bug): https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds

And here's how you can put together a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Hey, I've committed the changes. Can you please review it?

(In reply to ShubhamChinda from comment #5)

Hey, I've committed the changes. Can you please review it?

I don't see your changes. You need to submit them to phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Are you going to submit your patch for review?

Flags: needinfo?(shubhamchinda07)

(In reply to Dão Gottwald [::dao] from comment #7)

Are you going to submit your patch for review?

Hey, I'm little trouble in setting up the phabricator. Give me 2 days, I'll figure it out submit the patch.

Flags: needinfo?(shubhamchinda07)

having*(In reply to ShubhamChinda from comment #8)

(In reply to Dão Gottwald [::dao] from comment #7)

Are you going to submit your patch for review?

Hey, I'm little trouble in setting up the phabricator. Give me 2 days, I'll figure it out submit the patch.

Hi can i take over this issue?

First time. I have got phabricator, mercurial and have built firefox, just a little unsure how to submit a patch for the first time is all

(In reply to Chris Muldoon from comment #10)

Hi can i take over this issue?

First time. I have got phabricator, mercurial and have built firefox, just a little unsure how to submit a patch for the first time is all

Sure, instructions for submitting your patch are here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

I think this is ok? First time, so let me know of any noobie mistakes.

(In reply to Chris Muldoon from comment #13)

I think this is ok? First time, so let me know of any noobie mistakes.

Hey, would you mind telling me how did you set up the phabricator?
Thanks :)

Depends on D38420

Attachment #9079021 - Attachment is obsolete: true

Depends on D38420

Sorry about the mess, obviously i need to get my head around Mercurial a bit better :)

Assignee: nobody → chris.muldoon90
Attachment #9079025 - Attachment is obsolete: true
Attachment #9078892 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/879f7007188e
Clean up MozAutocompleteRichListitem fragment markup r=dao
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.