1563597 - [Fission] Can't observe "audio-playback" with JSWindowActor.

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P3)

Description

[Abdoulaye O. LY]

I will just paste here what Neil found out after his investigation on this:

"The issue is that JSWindowActorProtocol::Observe is filtering out all notifications that don't have a nsPIDOMWindowInner as its subject. Yet, the audio-playback notification uses a nsPIDOMWindowOuter object. This is a slightly different window object."

One of these two solutions should be considered:

1. support both nsPIDOMWindowInner and nsPIDOMWindowout in JSWindowActorProtocol.
2. use an inner window object for the audio notification.

Comment 1

[Neha Kochar [:neha]]

John, could you please look into this?

Comment 2

[John Dai[:jdai]]

It seems that there are some of jsm not use nsGlobalWindowInner as subject, I might release this constraint.

Comment 3

[John Dai[:jdai]]

Attachment: Bug 1563597 - Support nsGlobalWindowOuter as observer notification's subject;

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bbe229bcc0c
Support nsGlobalWindowOuter as observer notification's subject; r=nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8467385888
Fix lint errors. r=jdai

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6bbe229bcc0c
https://hg.mozilla.org/mozilla-central/rev/6a8467385888