1563769 - about:logins is still slow to display all the login count is greater than 100

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1560447 added a new API that does batch decryption of all logins which improved the performance of loading about:logins but there is still 25ms spent in the parent process converting nsILoginInfo objects to plain vanilla JS objects.

https://perfht.ml/2XMqaMM

getAllLoginsAsync can have an extra option that returns the stored logins as plain objects so they don't need to be deconstructed later.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

With returnPlainObjects implemented, https://perfht.ml/2XNAnsc

Comment 2

[Matthew N. [:MattN]]

title = title.replace(/^http(s)?:\/\//, "")

should be inside the catch block since .host should never contain the scheme. That may give you another speedup.

Comment 3

[Matthew N. [:MattN]]

Moving the regular expressions outside of the function would also mean they would only be compiled once.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

With display chunking of the login-list: https://perfht.ml/2XIvlgH

The last large chunk of time was spent doing layout of the 500 login-list-items. Moving this to a chunked layout where we do 50 items at a time takes longer overall but gives faster perceived performance by showing logins in the list in approximately 100ms versus waiting roughly 500ms when appending during with one fragment.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1563769 - Add an optional argument to getAllLoginsAsync that will return the login objects as plain JS objects. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1563769 - Append the children of the login-list using a fragment and prevent rendering the login-list twice during initial load. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1563769 - Compile the regular expressions for computing the login title only once. r?MattN

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1563769 - Display the count of logins earlier and chunk the layout of loginsin the list so we can display ASAP. r?MattN

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1563769 - Create login-list-item as a DOM fragment instead of a custom element to reduce overhead. r?MattN

Each custom element had its own shadowRoot, duplicated instances of the style sheet, and localization root. This patch also moves to a single 'click' event listener on the list instead of one for each item.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eac2cad57171
Append the children of the login-list using a fragment and prevent rendering the login-list twice during initial load. r=MattN
https://hg.mozilla.org/integration/autoland/rev/d9f8d63390ab
Compile the regular expressions for computing the login title only once. r=MattN
https://hg.mozilla.org/integration/autoland/rev/f8043220eb7e
Display the count of logins earlier and chunk the layout of loginsin the list so we can display ASAP. r=MattN
https://hg.mozilla.org/integration/autoland/rev/5f1acc97b6cc
Create login-list-item as a DOM fragment instead of a custom element to reduce overhead. r=MattN

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eac2cad57171
https://hg.mozilla.org/mozilla-central/rev/d9f8d63390ab
https://hg.mozilla.org/mozilla-central/rev/f8043220eb7e
https://hg.mozilla.org/mozilla-central/rev/5f1acc97b6cc