1563776 - If the Firefox source folder happens to be called firefox then jest misses a bunch of tests

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

If the Firefox source folder happens to be called firefox then jest misses a bunch of tests.

This is because of this line in devtools/client/debugger/jest-test.config.js:

modulePathIgnorePatterns: ["test/mochitest", "firefox/"],

The fix is simple:

modulePathIgnorePatterns: ["test/mochitest", "<rootDir>/firefox/"],

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1563776 - Fix debugger tests when fx source folder is called firefox r=jlast!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f93a2cb9622e
Fix debugger tests when fx source folder is called firefox r=jlast

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=f93a2cb9622e9767e0dd59590a7e8b47bee82377&selectedJob=255016845&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255016845&repo=autoland&lineNumber=744

Backout link: https://hg.mozilla.org/integration/autoland/rev/022ed2dbf7c0e62f9c5b74d3750d78c85ce5e423

[task 2019-07-05T21:56:27.470Z] Test Suites: 2 failed, 205 passed, 207 total
[task 2019-07-05T21:56:27.470Z] Tests: 5 failed, 8 skipped, 1736 passed, 1749 total
[task 2019-07-05T21:56:27.470Z] Snapshots: 440 passed, 440 total
[task 2019-07-05T21:56:27.470Z] Time: 61.477s
[task 2019-07-05T21:56:27.470Z] Ran all test suites in 5 projects.
[task 2019-07-05T21:56:27.470Z] error Command failed with exit code 1.
[task 2019-07-05T21:56:27.475Z] TEST-UNEXPECTED-FAIL jest | ● firefox commands › getProperties › empty response
[task 2019-07-05T21:56:27.475Z] TEST-UNEXPECTED-FAIL jest | ● firefox commands › getProperties › simple properties
[task 2019-07-05T21:56:27.475Z] TEST-UNEXPECTED-FAIL jest | ● firefox commands › getProperties › getter values
[task 2019-07-05T21:56:27.475Z] TEST-UNEXPECTED-FAIL jest | ● firefox commands › getProperties › new getter values
[task 2019-07-05T21:56:27.475Z] TEST-UNEXPECTED-FAIL jest | ● firefox onConnect › wait for sources at startup
[task 2019-07-05T21:56:27.475Z] TEST START | Stylelint
[task 2019-07-05T21:56:29.358Z] yarn run v1.9.4
[task 2019-07-05T21:56:29.358Z] $ stylelint "src/components/**/*.css"
[task 2019-07-05T21:56:29.358Z] Done in 1.51s.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=204b368396a4f64bba1e7bf8e65d791ffdbe37cb

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03aa91011325b983bd8aae54bd19c3b6f573c513

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd5b635002b
Fix debugger tests when fx source folder is called firefox r=jlast

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/3cd5b635002b