1564124 - Fix ESLint 6 related issues for no-async-promise-executor and no-misleading-character-class in newtab/

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Mark Banner (:standard8)]

In investigating upgrading to ESLint 6, there were some issues raised in newtab. These weren't easily to disable from the top-level, so I'm raising them before landing the upgrade.

browser/components/newtab/lib/ASRouterTargeting.jsm
  79:26  error  Promise executor functions should not be async.  no-async-promise-executor (eslint)
browser/components/newtab/lib/AboutPreferences.jsm
  137:36  error  Promise executor functions should not be async.  no-async-promise-executor (eslint)
browser/components/newtab/lib/LinksCache.jsm
  86:32  error  Promise executor functions should not be async.  no-async-promise-executor (eslint)
browser/components/newtab/lib/PersistentCache.jsm
  60:34  error  Promise executor functions should not be async.  no-async-promise-executor (eslint)
browser/components/newtab/lib/Tokenize.jsm
  32:26  error  Unexpected combined character in character class.  no-misleading-character-class (eslint)

Links to rules:

• https://eslint.org/docs/rules/no-async-promise-executor
• https://eslint.org/docs/rules/no-misleading-character-class

The main thing to note about the no-async-promise-executor is that it is highlighting instances where an error during await could be lost and the promise wouldn't reject. LinksCache.jsm looks most at risk of that, though we might want to consider if it is appropriate to rewrite the other functions.

For example, in ASRouterTargeting.jsm, CachedTargetingGetter.get could be simply declared as an async function.

Comment 1

[Mark Banner (:standard8)]

Note, I've just attached a ESLint 6 upgrade patch queue to bug 1551829.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Ed Lee :Mardak]

Hah whooops. Forgot to delete the strings helper in AboutPreferences.jsm as part of bug 1485002

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5168

Comment 5

[Mark Banner (:standard8)]

Thank you for working on this Ed.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/1f70de7f07a6