1565293 - [Export] Add What's New, sized welcome and bug fixes to New Tab Page

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P2)

Description

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/compare/459451d3058965930e7bd449a7f8e0145050dbf7...3731886d50d20c2836a9ca6c797a8cf4f8f3a9e1

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1565293 - Add What's New, sized welcome and bug fixes to New Tab Page

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f70de7f07a6
Add What's New, sized welcome and bug fixes to New Tab Page r=r1cky

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1565293 - Copy actually used asrouter.ftl to locales-src

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04eacc649af5
Copy actually used asrouter.ftl to locales-src r=fluent-reviewers,flod

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1f70de7f07a6
https://hg.mozilla.org/mozilla-central/rev/04eacc649af5

Comment 6

[Ed Lee :Mardak]

What's New panel with some test messages can be turned on with 3 pref changes:

browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing
{"id":"panel_local_testing", "cohort": "SHOW_TEST"}

browser.messaging-system.whatsNewPanel.enabled
true

browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
true

After restart, this should currently show 3 messages from Firefox hamburger menu -> 2nd last item What's New. It looks like for now, opening that item also triggers the what's new icon to appear next to the hamburger ?

Comment 7

[Ed Lee :Mardak]

Attachment: test what's new messages after setting 3 prefs

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA]

We have verified all the issues that were actionable for our point of view. Considering this I will remove the ni? request.

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a547b44c0ec3

Comment 10

[Ed Lee :Mardak]

(In reply to Andreea Pavel [:apavel] from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/a547b44c0ec3

Did you mean to uplift a different bug, perhaps bug 1562894? I'm surprised this patch even applied against mozilla-beta as there's various other uplifts to beta already… ?? Although perhaps they were all in different parts of bundle.js…

Comment 11

[Andreea Pavel [:apavel]]

(In reply to Ed Lee :Mardak (PTO Jul 30 - Aug 5) from comment #10)

(In reply to Andreea Pavel [:apavel] from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/a547b44c0ec3

Did you mean to uplift a different bug, perhaps bug 1562894? I'm surprised this patch even applied against mozilla-beta as there's various other uplifts to beta already… ?? Although perhaps they were all in different parts of bundle.js…

That got uplifted by mistake, you have the details here. Sorry for the confusion

https://bugzilla.mozilla.org/show_bug.cgi?id=1562894#c16

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/03b028ae464bb042d8141ba0f45f5bd99ab81833