Closed Bug 1565293 Opened 3 months ago Closed 3 months ago

[Export] Add What's New, sized welcome and bug fixes to New Tab Page

Categories

(Firefox :: New Tab Page, task, P2, enhancement)

task
P2
enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

Attachments

(3 files)

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f70de7f07a6
Add What's New, sized welcome and bug fixes to New Tab Page r=r1cky
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04eacc649af5
Copy actually used asrouter.ftl to locales-src r=fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

What's New panel with some test messages can be turned on with 3 pref changes:

browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing
{"id":"panel_local_testing", "cohort": "SHOW_TEST"}

browser.messaging-system.whatsNewPanel.enabled
true

browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
true

After restart, this should currently show 3 messages from Firefox hamburger menu -> 2nd last item What's New. It looks like for now, opening that item also triggers the what's new icon to appear next to the hamburger ?

Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)
Depends on: 1557304
Blocks: 1566202

We have verified all the issues that were actionable for our point of view. Considering this I will remove the ni? request.

Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)

(In reply to Andreea Pavel [:apavel] from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/a547b44c0ec3

Did you mean to uplift a different bug, perhaps bug 1562894? I'm surprised this patch even applied against mozilla-beta as there's various other uplifts to beta already… ?? Although perhaps they were all in different parts of bundle.js…

Flags: needinfo?(apavel)

(In reply to Ed Lee :Mardak (PTO Jul 30 - Aug 5) from comment #10)

(In reply to Andreea Pavel [:apavel] from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/a547b44c0ec3

Did you mean to uplift a different bug, perhaps bug 1562894? I'm surprised this patch even applied against mozilla-beta as there's various other uplifts to beta already… ?? Although perhaps they were all in different parts of bundle.js…

That got uplifted by mistake, you have the details here. Sorry for the confusion

https://bugzilla.mozilla.org/show_bug.cgi?id=1562894#c16

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/03b028ae464bb042d8141ba0f45f5bd99ab81833

Flags: needinfo?(apavel)
You need to log in before you can comment on or make changes to this bug.