Closed Bug 1564138 Opened 1 year ago Closed 1 year ago

Prop-types failures in devtools when upgrading to the latest eslint-plugin-react

Categories

(DevTools :: General, task)

task
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: standard8, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

I'm currently working on upgrading to ESLint 6. As part of that, I am upgrading eslint-plugin-react to the latest (7.14.2) and I'm seeing the new errors.

It seems that probably the 7.14.0 release has added some new things for prop type validation.

devtools/client/application/src/components/Worker.js
  199:32  error  'worker.lastUpdateTime' is missing in props validation  react/prop-types (eslint)
  206:27  error  'worker.lastUpdateTime' is missing in props validation  react/prop-types (eslint)
  236:38  error  'worker.url' is missing in props validation             react/prop-types (eslint)

devtools/client/shared/components/List.js
  150:18  error  'item.key' is missing in props validation  react/prop-types (eslint)

devtools/client/shared/components/tree/TreeRow.js
  260:18  error  'member.loading' is missing in props validation  react/prop-types (eslint)

devtools/client/shared/components/tree/TreeView.js
  561:27  error  'provider.getLevel' is missing in props validation  react/prop-types (eslint)
  561:47  error  'provider.getLevel' is missing in props validation  react/prop-types (eslint)

devtools/client/webconsole/components/Output/Message.js
  176:26  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)
  177:24  error  'serviceContainer.onMessageHover' is missing in props validation        react/prop-types (eslint)
  198:26  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)
  200:32  error  'serviceContainer.jumpToExecutionPoint' is missing in props validation  react/prop-types (eslint)
  323:30  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  326:30  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  327:42  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  360:40  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  385:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  389:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  395:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  431:24  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/238a8eb35207
Fix DevTools PropTypes errors when updating eslint. r=Ola.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1567134
You need to log in before you can comment on or make changes to this bug.