1564138 - Prop-types failures in devtools when upgrading to the latest eslint-plugin-react

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Mark Banner (:standard8)]

I'm currently working on upgrading to ESLint 6. As part of that, I am upgrading eslint-plugin-react to the latest (7.14.2) and I'm seeing the new errors.

It seems that probably the 7.14.0 release has added some new things for prop type validation.

devtools/client/application/src/components/Worker.js
  199:32  error  'worker.lastUpdateTime' is missing in props validation  react/prop-types (eslint)
  206:27  error  'worker.lastUpdateTime' is missing in props validation  react/prop-types (eslint)
  236:38  error  'worker.url' is missing in props validation             react/prop-types (eslint)

devtools/client/shared/components/List.js
  150:18  error  'item.key' is missing in props validation  react/prop-types (eslint)

devtools/client/shared/components/tree/TreeRow.js
  260:18  error  'member.loading' is missing in props validation  react/prop-types (eslint)

devtools/client/shared/components/tree/TreeView.js
  561:27  error  'provider.getLevel' is missing in props validation  react/prop-types (eslint)
  561:47  error  'provider.getLevel' is missing in props validation  react/prop-types (eslint)

devtools/client/webconsole/components/Output/Message.js
  176:26  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)
  177:24  error  'serviceContainer.onMessageHover' is missing in props validation        react/prop-types (eslint)
  198:26  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)
  200:32  error  'serviceContainer.jumpToExecutionPoint' is missing in props validation  react/prop-types (eslint)
  323:30  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  326:30  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  327:42  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  360:40  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  385:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  389:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  395:28  error  'serviceContainer.onViewSource' is missing in props validation          react/prop-types (eslint)
  431:24  error  'serviceContainer.canRewind' is missing in props validation             react/prop-types (eslint)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1564138 - Fix DevTools PropTypes errors when updating eslint. r=ola.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/238a8eb35207
Fix DevTools PropTypes errors when updating eslint. r=Ola.

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/238a8eb35207