1564164 - [jsdbg2] Split up Debugger.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jim Blandy :jimb]

The Debugger implementation is currently a single 428kiB, 13kloc file, js/src/vm/Debugger.cpp. Phabricator refuses to colorize the code for patch review due to its size. It's difficult to find the code one is looking for.

The implementation should be relocated to its own directory, js/src/dbg, and broken up into separate files. There would ideally be one file per Debugger API object type (Debugger, Debugger.Object, Debugger.Script, and so on). At first, Debugger.h could remain a single file, but as separable pieces are identified, it could be broken up. Other files for shared functionality could be pulled out as needed.

A few other files in js/src/vm that probably also belong in js/src/dbg: DebuggerMemory.cpp, and perhaps the UbiNode... files.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move Debugger.cpp, DebuggerMemory.cpp, and related files into js/src/dbg. r?jorendorff

Comment 2

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move EnterDebuggeeNoExecute and LeaveDebuggeeNoExecute into their own header, dbg/NoExecute.h. r?jorendorff

Depends on D37334

Comment 3

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move DebuggerObject into its own file, js/src/dbg/Object.cpp. r?jorendorff

Depends on D37335

Comment 4

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move DebuggerFrame into its own file, js/src/dbg/Frame.cpp. r?jorendorff

Comment 5

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move DebuggerEnvironment into its own file, js/src/dbg/Environment.cpp. r?jorendorff

Depends on D37357

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e59a0e725e9f
Move Debugger.cpp, DebuggerMemory.cpp, and related files into js/src/dbg. r=jorendorff

Comment 7

[Jim Blandy :jimb]

Attachment: Bug 1564164: Let all DebuggerFoo::initClass methods take their arguments in a consistent order. r?jorendorff

Comment 8

[Jim Blandy :jimb]

Attachment: Bug 1564164: Give Debugger.Script instances their own NativeObject subclass, DebuggerScript.

Depends on D37508

Comment 9

[Jim Blandy :jimb]

Attachment: Rebased version of D37334.

Here's a version of D37334 rebased on top of the changes to js/src/vm/Debugger.cpp and Debugger.h in central.

Comment 10

[Phabricator Automation]

Comment on attachment 9076984 [details]
Bug 1564164: Give Debugger.Script instances their own NativeObject subclass, DebuggerScript.

Revision D37509 was moved to bug 1564170. Setting attachment 9076984 [details] to obsolete.

Comment 11

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move DebuggerScript into its own file, js/src/dbg/Script.cpp. r?jorendorff

Depends on D37528

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e59a0e725e9f

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89e578d07137
Move EnterDebuggeeNoExecute and LeaveDebuggeeNoExecute into their own header, dbg/NoExecute.h. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/6c763326b518
Move DebuggerObject into its own file, js/src/dbg/Object.cpp. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/10ac90913cdf
Move DebuggerFrame into its own file, js/src/dbg/Frame.cpp. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/530d71d677d5
Move DebuggerEnvironment into its own file, js/src/dbg/Environment.cpp. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/5fe29dc3c21e
Let all DebuggerFoo::initClass methods take their arguments in a consistent order. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/0f741c61e16b
Move DebuggerScript into its own file, js/src/dbg/Script.cpp. r=jorendorff

Comment 14

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/89e578d07137
https://hg.mozilla.org/mozilla-central/rev/6c763326b518
https://hg.mozilla.org/mozilla-central/rev/10ac90913cdf
https://hg.mozilla.org/mozilla-central/rev/530d71d677d5
https://hg.mozilla.org/mozilla-central/rev/5fe29dc3c21e
https://hg.mozilla.org/mozilla-central/rev/0f741c61e16b

Comment 15

[Jim Blandy :jimb]

Attachment: Bug 1564164: Move DebuggerSource into its own file. r?jorendorff

This adds js/src/dbg/Source.{cpp,h}, and moves DebuggerSource's definition
there. No intended change in implementation or visible behavior.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c345c044ca1
Move DebuggerSource into its own file. r=jorendorff

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2c345c044ca1