Closed Bug 1564238 Opened 7 months ago Closed 6 months ago

Enable kinetic scrolling for Linux touchpads by default (on Wayland; X still requires setting MOZ_USE_XINPUT2=1)

Categories

(Core :: Widget: Gtk, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: botond, Assigned: botond)

References

(Regressed 1 open bug)

Details

Attachments

(1 file)

In bug 1213601 we added kinetic scrolling for Linux touchpads. It landed behind a pref, apz.gtk.kinetic_scroll.enabled, due to the potential for regressions and some issues we couldn't figure out how to solve (like bug 1554408).

Now that it's been in the tree for a few weeks, and the people who tried it out haven't reported any unexpected issues, I think we should try enabling it by default. If it's only problematic for a few users (such as the reporter of bug 1554408), and those users are happy to flip the pref back off as a workaround, we could ship it as the default.

Summary: Enable apz.gtk.kinetic_scroll.enabled by default → Enable kinetic scrolling for Linux touchpads by default
Type: defect → enhancement

(I deliberately waited until the trains switched over to 70, so that we have a full nightly + beta cycle to catch any fallout from this.)

MOZ_USE_XINPUT2 should also be set to 1 by default? otherwise there is still no kinetic scrolling.

Hi, I'm the reporter of bug 1554408. Just to make sure, will it be possible to disable the kinetic scroll simply by setting apz.gtk.kinetic_scroll.enabled to false? For those of us who prefer smooth over kinetic scrolling...

(In reply to violet.bugreport from comment #3)

MOZ_USE_XINPUT2 should also be set to 1 by default? otherwise there is still no kinetic scrolling.

There is on Wayland :)

(In reply to violet.bugreport from comment #3)

MOZ_USE_XINPUT2 should also be set to 1 by default?

I don't think we can, until the dependencies of bug 1207700 are fixed.

otherwise there is still no kinetic scrolling.

You're right, this does mean that on X kinetic scrolling is still not the default, only on Wayland as Greg says. I'm adjusting the bug title to reflect this more accurately.

Summary: Enable kinetic scrolling for Linux touchpads by default → Enable kinetic scrolling for Linux touchpads by default (on Wayland; X still requires setting MOZ_USE_XINPUT2=1)

(In reply to Yariv from comment #4)

Just to make sure, will it be possible to disable the kinetic scroll simply by setting apz.gtk.kinetic_scroll.enabled to false? For those of us who prefer smooth over kinetic scrolling...

Yep, you will be able to disable it by changing the pref.

Meanwhile, if someone figures out how to get scrolling that's smooth and kinetic on touchpads like yours, we would still welcome a patch for that!

(In reply to Botond Ballo [:botond] from comment #7)

Yep, you will be able to disable it by changing the pref.

Meanwhile, if someone figures out how to get scrolling that's smooth and kinetic on touchpads like yours, we would still welcome a patch for that!

As far as I've seen Firefox behaves the same as other 'native' GTK3 apps (gedit etc) with regard to touchpad scrolling on Wayland. These apps don't have smooth touchpad scroll either. I guess that the best approach would be to add support for smooth touchpad scroll to GTK itself, however that could take a while.

Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7bd517e7949
Enable kinetic scrolling by default for Linux touchpads. r=karlt
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1592458
You need to log in before you can comment on or make changes to this bug.