1564329 - Add previous/next buttons to search field

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Sebastian Zartner [:sebo]]

The search field in the Inspector currently only supports keyboard navigation via Enter to jump to the next match and Shift + Enter to jump to the previous match.

Additionally to that there should be two buttons as a visual UI for this action like we have them in other places like the Debugger panel or the global Firefox search.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Karan, you asked to work on that feature (in Bug 1939915), the bug is now yours :)
I guess we can take some inspiration from the search input in the debugger

Comment 3

[Karan Yadav]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)

Karan, you asked to work on that feature (in Bug 1939915), the bug is now yours :)
I guess we can take some inspiration from the search input in the debugger

Thank you for assigning the bug to me! I'll look into it and see how we can leverage the search input behavior from the debugger for inspiration.
Let me know if there's any specific guidance or additional context you'd like me to consider.

Comment 4

[Karan Yadav]

Attachment: Bug 1564329 - [devtools] Add the navigations buttons in inspector html search. r=#devtools-reviewers

Comment 5

[Karan Yadav]

Attachment: Bug 1564329 - [devtools] Add the test for html search. r=#devtools-reviewers

Comment 6

[Karan Yadav]

Attachment: Bug 1564329 - [devtools] Add the test for html search. r=#devtools-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75f0f5d12b1d
[devtools] Add the navigations buttons in inspector html search. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e7a4da7069d1
[devtools] Add the test for html search. r=devtools-reviewers,nchevobbe

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/75f0f5d12b1d
https://hg.mozilla.org/mozilla-central/rev/e7a4da7069d1