1564585 - wrong colors for ATI Radeon RX560

Status: NEW

(Core :: Graphics: Color Management, defect, P3)

Description

[Ulrich Windl]

Attachment: Screen shot showing wrong colors

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Browsing the Web some color images show wrong colors. Most notable with green faces.
See attachment (right to left): File loaded in Firefox, image copied to GIMP (via clipboard), images loaded from URI (one without colorspace conversion, the other with), Downloaded image displayed with ImageMagick.

Firefox is 60.7.2esr on openSUSE Leap 15.1 (64 bit)

Actual results:

Some colors are displayed incorrectly, probably due to 10-bit color depth support.

Expected results:

Colors should be correct.

Comment 1

[Ulrich Windl]

Attachment: Gamut from display profile (solid) compared with AdobeRGB (dashed) in CIE u'v'

Maybe I should note that I also have a calibrated "wide gamut" display (EIZO SX2462W) that partially exceeds the AdobeRGB (1998) color space.

Comment 2

[Peter Magyari (Desktop QA)]

Hi Ulrich,

I wasn't able to reproduce this issue on Ubuntu 18.0.4 (64-bit) using Firefox 60.7.2esr (20190619235516) or Firefox 68.0esr (20190705221915).
Unfortunately I do not have access to openSUSE Leap 15.1, but my graphics card is similar to the one you are using (ATI Radeon Rx550) and the colors were accurately displayed on my end.

Please test if the issue occurs on a new profile, you can find the steps to do that below:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Thank you for taking the time to report this issue!

Comment 3

[Ulrich Windl]

Attachment: Partial screen shot with Firefox 60.7.2 and a new profile

As long I we don't know the root of the problem (could be outside Firefox as well), it's hard to get the bug nailed down. At least with a new profile (all defaults), the rendering problem is the same.

Comment 4

[Ulrich Windl]

Attachment: Screenshot showing the Tux logo in GIMP (correct) and Firefox (wrong)

The odd thing is that some images have no problem at all, while others have: For example if I visit the Wikipedia page for Linux Torvalds, the portraits look correct, but the Tux logo (https://upload.wikimedia.org/wikipedia/commons/thumb/3/35/Tux.svg/170px-Tux.svg.png) has bluish-green feet. If I display a color circle as PDF in Firefox, all colors look OK.
Also when loaded in GIMP, the same Tux logo looks correct.
When I load http://www.colorreference.de/targets/target.jpg (IT 8.7 target) in Firefox, the colors seem correct also, however.

So quite a lot of images look correct, but some do not. For example:
About 1/3rd of the larger faces are green, while the others look OK at https://theracecardproject.com/skin-color-isnt-culture/ (best seen with scripts disabled).

Comment 5

[Darkspirit]

Does it look the same with layers.acceleration.force-enabled;true (restart required)?
Is this bug still present with latest Nightly? Thanks!

Comment 6

[Peter Magyari (Desktop QA)]

Hi Ulrich,

Could you try if it also occurs on the latest nightly and layers.acceleration.force-enabled set to "true" ?

Thank you!

Comment 7

[Darkspirit]

1. Please update your regular Firefox. Does this problem still happen? (If yes, which Firefox version do you have now?)
2. Does it still happen with your regular Firefox if you set layers.acceleration.force-enabled to true and restart Firefox?
3. Does it still happen with Nightly? Unless you have proprietary Nvidia drivers or a super old Mesa version it uses WebRender (the new OpenGL compositor) by default. Otherwise force-enable it by opening about:config, setting gfx.webrender.all to true and restarting Nightly. bug 1493198 added HDR support in Firefox 64.

Comment 8

[Ulrich Windl]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #5)

Does it look the same with layers.acceleration.force-enabled;true (restart required)?
Is this bug still present with latest Nightly? Thanks!

I downloaded and started Nightly with a new profile: Julian Assange still looks green.
I applied the recommended setting, restarted Nightly, and Julian Assange is still green.

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #7)

3. Does it still happen with Nightly? Unless you have proprietary Nvidia drivers or a super old Mesa version it uses WebRender (the new OpenGL compositor) by default. Otherwise force-enable it by opening about:config, setting gfx.webrender.all to true and restarting Nightly. bug 1493198 added HDR support in Firefox 64.

With an ATI graphics card I do not see the dependency with the Nvidia driver. But anyway: I don't have a Nvidia driver installed.
My Mesa version is Mesa-18.3.2-lp151.22.4.x86_64.
With gfx.webrender.all=true, Julian Assange is still green. Maybe the green looks a bit more saturated, but I'm not 100% sure.
However I saw that gfx.webrender.enabled was still false, so I toggled that, restarted Nightly, and tried again: Julian Assange is still green.

Comment 9

[Timothy Nikkel (:tnikkel)]

Can you provide your about:support? Particularly the CMSOutputProfile part.

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #9)

Can you provide your about:support? Particularly the CMSOutputProfile part.

Note that you will need to use 69 beta or 70 nightly (see bug 1556822) in order for this info to be included. It will also be good to see that this still reproduces in 70 nightly anyways :).

Comment 11

[Ulrich Windl]

Attachment: ICC profile with size 833600 bytes

(In reply to Timothy Nikkel (:tnikkel) from comment #9)

Can you provide your about:support? Particularly the CMSOutputProfile part.
"CMSOutputProfile : 833600 bytes, too large" 8-(
I'm attaching the profile in question. Seems to be a v2.2 monitor profile made by Argyll CMS (Created with DisplayCAL 3.5.3.0 and ArgyllCMS 1.9.). Maybe that helps.

(In reply to Andrew Osmond [:aosmond] from comment #10)

(...) It will also be good to see that this still reproduces in 70 nightly anyways :).

The Nightly four days ago was "Mozilla Firefox 70.0a1" (20190731215544)!

Comment 12

[Ulrich Windl]

I'm still unsure what the pattern is:
I have a PNG image with different skin colors (24 bit true color, GIMP built-in sRGB profile), and almost every color is green when viewed with Firefox.
I also have a JPEG image of an IT8.7 calibration chart (no ICC profile), and there all colors look correct when viewed with Firefox.
When I save the PNG with skin colors as PNG (24 bit true color), but without an ICC profile, then the colors are correct, too.

Comment 13

[Ulrich Windl]

Made the following test (meanwhile Firefox ESR 68.1.0):
Disable monitor profile, load the test page: Image looks OK.
Re-enable profile while Firefox is active, then reload the page: Image still looks OK
Restart Firefox, then load the test page: Image look wrong (green face)

Comment 14

[Ulrich Windl]

Problem is still present with OpenSUSE Leap 15.2 (X.Org version: 1.20.3) and Firefox 78.3.0.
When starting DisplayCal, I see this message; maybe it's related to the problem:
03:46:02,933 Dispwin: Warning - new_dispwin: Expected VideoLUT depth 8 doesn't match actual 10
03:46:02,958 VideoLUT has 1024 entries, interpolating to 256

Maybe this is the problem:
(II) AMDGPU(0): Creating default Display subsection in Screen section
"Default Screen Section" for depth/fbbpp 24/32
(==) AMDGPU(0): Depth 24, (--) framebuffer bpp 32
(II) AMDGPU(0): Pixel depth = 24 bits stored in 4 bytes (32 bpp pixmaps)
(==) AMDGPU(0): Default visual is TrueColor
(==) AMDGPU(0): RGB weight 888
(II) AMDGPU(0): Using 8 bits per RGB (8 bit DAC)
(--) AMDGPU(0): Chipset: "Radeon RX 560 Series" (ChipID = 0x67ef)

Comment 15

[Ulrich Windl]

Attachment: Some correctly colored faces at the left, and a green face on the right

I upgraded my OS from openSUSE Leap 15.2 to 15.3 and I also used Mozilla's Firefox ESR 91.4.1 to test:
Unfortunately some faces are still green. On the other hand when I open a local JPG with an IT-8.7 target (high gamut also), the colors are correct.

Comment 16

[Ulrich Windl]

Attachment: IT-8.7/2 target displayed in firefox shows correct colors

For some reason the screenshots when being displayed again here (on the same machine and in the same session) are less saturated than the original screen was.

Comment 17

[Ulrich Windl]

Attachment: about:support (Text version, German)

(In reply to Timothy Nikkel (:tnikkel) from comment #9)

Can you provide your about:support? Particularly the CMSOutputProfile part.

Yes ;-) Sorry for the delay. This is from an original mozilla build (current ESR).

Comment 18

[Ulrich Windl]

Attachment: Partial screenshot from https://en.wikipedia.org/w/index.php?title=Julian_Assange&oldid=1080364470

Not having changed the hardware the colors look OK now. I only updated the software:
Firefox 91.7.0esr (64-bit)
xorg-x11-server-1.20.3-22.5.47.1.x86_64
xorg-x11-7.6_1-1.22.noarch

GPU details:
amdgpu: ATOM BIOS: 113-TIC33062-001
kernel: [drm] Initialized amdgpu 3.39.0 20150101 for 0000:01:00.0 on minor 0
AMDGPU(0): Depth 24, (--) framebuffer bpp 32
AMDGPU(0): Pixel depth = 24 bits stored in 4 bytes (32 bpp pixmaps)
AMDGPU(0): Default visual is TrueColor
AMDGPU(0): RGB weight 888
AMDGPU(0): Using 8 bits per RGB (8 bit DAC)
AMDGPU(0): Chipset: "Radeon RX 560 Series" (ChipID = 0x67ef)

Screen details:
AMDGPU(0): Manufacturer: ENC Model: 2078
AMDGPU(0): Gamma: 2.20
MDGPU(0): Supported color encodings: RGB 4:4:4 YCrCb 4:4:4
AMDGPU(0): redX: 0.680 redY: 0.310 greenX: 0.206 greenY: 0.693
AMDGPU(0): blueX: 0.151 blueY: 0.055 whiteX: 0.313 whiteY: 0.329
AMDGPU(0): Monitor name: SX2462W
AMDGPU(0): Output DVI-D-0 connected

Firefox Details:
WebRender
GLX 1.4
X.Org -- Radeon RX 560 Series (POLARIS11, DRM 3.39.0, 5.3.18-150300.59.60-preempt, LLVM 11.0.1)
4.6 (Compatibility Profile) Mesa 20.2.4
mesa/radeonsi

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.