1564638 - Update Linux to Rust beta 1.37

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Eric Rahm [:erahm]]

We need to update a platform to the latest rust beta 1.37 in order to enable rust PGO on Firefox nightly for testing. Lets just do Windows for now.

Comment 1

[Eric Rahm [:erahm]]

Windows still has a build issue upstream, lets just do Linux for now.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Bug 1564638 - Update Linux to Rust beta 1.37. r=froydnj,glandium

Comment 3

[Eric Rahm [:erahm]]

Currently busted in the repackaging step, it looks like the install script for rust-src-beta has DOS line endings causing the interpreter line to be invalid.

Comment 4

[Eric Rahm [:erahm]]

With a hack to deal with the bogus line endings in repack_rust.py we've got functioning builds. We either need to land the workaround or wait for the fix on rust nightly to get backported to rust beta 1.37 and then for the next build to come along.

Comment 5

[Eric Rahm [:erahm]]

(In reply to Eric Rahm [:erahm] from comment #1)

Windows still has a build issue upstream, lets just do Linux for now.

There's a pending PR for a proper fix, that still needs to get reviewed and uplifted to rust beta 1.37 before we can enable on Windows.

Comment 6

[Eric Rahm [:erahm]]

(In reply to Eric Rahm [:erahm] from comment #3)

Currently busted in the repackaging step, it looks like the install script for rust-src-beta has DOS line endings causing the interpreter line to be invalid.

There's a fix landed in rust 1.38 nightly, but it hasn't been approved for uplift yet. I'm inclined to just add my workaround to our repackaging step.

Comment 7

[Eric Rahm [:erahm]]

Attachment: Bug 1564638 - Fix line endings in rust repack step. r=glandium

DOS line endings ended up in some of rust's install.sh scripts. This adds a
step to proprecess the scripts to use proper line endings. We can remove this
once a proper fix is landed upstream and approved for backporting to rust
beta 1.37 or we can just keep this step in case the problem happens again.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2adf316da439
Update Linux to Rust beta 1.37. r=froydnj

Comment 9

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 2adf316da439 (bug 1564638) for wrench failures

Backout: https://hg.mozilla.org/integration/autoland/rev/552370ccbbbe6c5e98fb84cc23c7847c52895240

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2adf316da439ddc4d0979d2520c239b29394235a&selectedJob=258178167

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=258178167&repo=autoland

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a4f3976b34
Update Linux to Rust beta 1.37. r=froydnj,glandium

Comment 11

[Oana Pop-Rus]

Backed out changeset a1a4f3976b34 (bug 1564638) for wrench-deps bustages.

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=a1a4f3976b34a43ea639f4f4c1bd59e98609ecc8

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=258218093&repo=autoland

Backout:https://hg.mozilla.org/integration/autoland/rev/44cd8bfdf0f3a92eb9e5664f5cc182247f0d1b91

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/530d09741a0d
Update Linux to Rust beta 1.37. r=froydnj,glandium

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/530d09741a0d