Closed
Bug 1564815
Opened 5 years ago
Closed 5 years ago
GeckoView's CHANGELOG has incorrect links due to reused link references
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(firefox69 wontfix, firefox70 fixed)
RESOLVED
FIXED
mozilla70
People
(Reporter: robwu, Assigned: fluffyemily)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Every link in GeckoView's CHANGELOG.md should have a unique reference (i.e. [link here][reference here]
). This is not the case; there are four instances of reused references, resulting in links that contain the wrong target URL.
$ wget https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
$ grep -oP '^\[[0-9.]+' CHANGELOG.md | sort | uniq -c | sort -n
...
2 [67.2
2 [68.23
2 [69.2
2 [69.3
- 67.2 - :69 and :142
- 68.23 - :115 and :120
- 69.2 - :16 and :27
- 69.3 - :21 and :28
Comment 1•5 years ago
|
||
Is this a merge issue? We should also linkify bug numbers in CHANGELOG.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → etoop
Assignee | ||
Comment 2•5 years ago
|
||
...em. 5. Add links to changelog entries that did not have them, but should have
Updated•5 years ago
|
Attachment #9083376 -
Attachment description: Fix broken CHANGELOG links. 1. Move all link referneces into single list to make is easier to spot duplicates 2. Remove duplicates 3. Update links that are broken 4. Create variable for javadoc_url so that broken relative paths are not a problem. → Fix broken CHANGELOG links.
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ad8ff235dc4
Fix broken CHANGELOG links. r=agi
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Comment 5•5 years ago
|
||
Hmm, removing the additional newlines between each change log entry didn't really improve the readability when looking at the unformatted source file in my opinion...
Comment 6•5 years ago
|
||
firefox69=wontfix because we don't need to uplift changelog fixes to Beta.
status-firefox69:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•