Closed Bug 1564815 Opened 5 months ago Closed 4 months ago

GeckoView's CHANGELOG has incorrect links due to reused link references

Categories

(GeckoView :: General, enhancement, P3)

Unspecified
All
enhancement

Tracking

(firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: robwu, Assigned: fluffyemily)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Every link in GeckoView's CHANGELOG.md should have a unique reference (i.e. [link here][reference here]). This is not the case; there are four instances of reused references, resulting in links that contain the wrong target URL.

$ wget https://hg.mozilla.org/mozilla-central/raw-file/tip/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
$ grep -oP '^\[[0-9.]+' CHANGELOG.md | sort | uniq -c | sort -n
...
      2 [67.2
      2 [68.23
      2 [69.2
      2 [69.3

Is this a merge issue? We should also linkify bug numbers in CHANGELOG.

Type: defect → enhancement
Priority: -- → P3
Assignee: nobody → etoop

...em. 5. Add links to changelog entries that did not have them, but should have

Attachment #9083376 - Attachment description: Fix broken CHANGELOG links. 1. Move all link referneces into single list to make is easier to spot duplicates 2. Remove duplicates 3. Update links that are broken 4. Create variable for javadoc_url so that broken relative paths are not a problem. → Fix broken CHANGELOG links.
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ad8ff235dc4
Fix broken CHANGELOG links.  r=agi
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Hmm, removing the additional newlines between each change log entry didn't really improve the readability when looking at the unformatted source file in my opinion...

firefox69=wontfix because we don't need to uplift changelog fixes to Beta.

You need to log in before you can comment on or make changes to this bug.