1564854 - Support before/after mode in the new architecture

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

It isn't the case currently:
https://bugzilla.mozilla.org/show_bug.cgi?id=1562642#c21
and I didn't have anything at review phase

Comment 1

[Marco Castelluccio [:marco]]

It is already executed as it is part of the "eslint" job.

In the last run of the bot (on https://phabricator.services.mozilla.com/D37217), your issue was detected (https://tools.taskcluster.net/groups/FNik4vZ1STCPEP9t5OC1sQ/tasks/TBe_bvd_SKyVqV_s6xQEPw/runs/0/logs/public%2Flogs%2Flive.log#L306) but it was not published (https://tools.taskcluster.net/groups/FLU_Sen1Rm-hDmBMW49aKw/tasks/FLU_Sen1Rm-hDmBMW49aKw/runs/0/logs/public%2Flogs%2Flive.log#L37).

Comment 2

[Victor Porof [:vporof][:vp]]

Bug title should be changed.

Normally I see those issues in Phabricator, e.g. https://phabricator.services.mozilla.com/D36231#inline-223819

Comment 3

[Sylvestre Ledru [:Sylvestre]]

This is because the line detected by Prettier wasn't touched by my patch.
We have plans to change that.

Comment 4

[Mark Banner (:standard8)]

I believe this is all working fine now - we have prettier at the review phase, and there's now better detection on what is/isn't included.