1564889 - (SQLite3.29.0) Upgrade to SQLite 3.29.0

Status: RESOLVED FIXED

(Toolkit :: Storage, task, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1544443 +++

It's not actually out yet, but we found an issue with the latest snapshot build and wanted to be able to set deps for it.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

And there it is!

2019-07-10 - Release 3.29.0

Version 3.29.0 is a regularly scheduled maintenance release of SQLite containing miscellaneous performance and feature enhancements. See the change log for details.

Beginning with this release, the double-quoted string literal misfeature is deprecated. The misfeature is still enabled by default, for legacy compatibility, however developers are encouraged to disable it at compile-time using the -DSQLITE_DQS=0 option, or at run-time using the SQLITE_DBCONFIG_DQS_DML and SQLITE_DBCONFIG_DQS_DDL actions to the sqlite3_db_config() interface. This is especially true for double-quoted string literals in CREATE TABLE and CREATE INDEX statements, as those elements can cause unexpected problems following an ALTER TABLE. See ticket 9b78184be266fd70 for an example.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)

Beginning with this release, the double-quoted string literal misfeature is deprecated. The misfeature is still enabled by default, for legacy compatibility, however developers are encouraged to disable it at compile-time using the -DSQLITE_DQS=0 option, or at run-time using the SQLITE_DBCONFIG_DQS_DML and SQLITE_DBCONFIG_DQS_DDL actions to the sqlite3_db_config() interface. This is especially true for double-quoted string literals in CREATE TABLE and CREATE INDEX statements, as those elements can cause unexpected problems following an ALTER TABLE. See ticket 9b78184be266fd70 for an example.

Is this something we care about?

Try push without that change:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e907409cfa13388ef529c13d73498057a4d40a8

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

it is recommended, so we should at least file a followup to enable it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I did a Try push with SQLITE_DQS set to 0 and got a lot of orange. Looks like we'll indeed want to move that to a follow-up.
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0e0c565c849bd9ac831794d51cf7a10858ddcc7f

I am going to remove the aarch64 byte order setting from moz.build, however, since that was fixed upstream in the 3.25 release.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1564889 - Upgrade to SQLite 3.29.0. r=mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aa8e9303ce0
Upgrade to SQLite 3.29.0. r=mak

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6aa8e9303ce0