1564974 - Deploy webcompat v4.3.3 addon via gofaster to Release

Status: RESOLVED WONTFIX

(Firefox :: System Add-ons: Off-train Deployment, task)

Description

[Mike Taylor [:miketaylr]]

Attachment: webcompat-4.3.3.xpi

It will land in Nightly, and has been approved for Beta uplift. This bug exists to get it to Release before a dot release ships.

Note: this XPI should only be shipped to Release.

Comment 1

[Mike Taylor [:miketaylr]]

PI request filed here: https://jira.mozilla.com/browse/PI-193

Comment 2

[Luciana queirolo]

Hi,

Checked the issue on Windows 10 x64, MacOS 10.14 and Ubuntu 18.04.2 x64 and the form labels were displayed after installing the addon webcompat-4.3.3.xpi

Thanks!

Comment 3

[Mike Taylor [:miketaylr]]

Wei, Rehan, can we get the webcompat-4.3.3.xpi signed for Balrog and push to the test channel (release-sysaddon)? Thanks

PI has tested it in Comment #2.

Comment 4

[:wezhou]

Attachment: signed.9077158.xpi

Signed file attached. Pleast test.

Thanks.

Comment 5

[Dennis Schubert [:denschub]]

Attachment: webcompat-4.3.3.unsigned.xpi

:wezhou, I did a safety-check run with your XPI and noticed that, although everything is working just fine, including the fix we're actually trying to get out, the XPI I initially built contains some recent refactoring that have never been in release. Although I see no reason why this could break release, I don't feel comfortable to run with this, so I attached a new version. This XPI includes only code that already got shipped to release users via the train, plus one additional WebCompat intervention that's mentioned here, no additional changes.

Can you sign it again? Sorry for that oversight on my end, and sorry for having you do things twice.

Comment 6

[:wezhou]

Attachment: signed.9077369.xpi

Signed file attached. Please test.

Thanks.

Comment 7

[Mike Taylor [:miketaylr]]

(probably doesn't make sense for me to be assigned now that it's changed products)

Comment 8

[Rehan Dalal (Inactive)]

This has been added to the test channel (release-sysaddon) and is ready for QA testing.

It has also been staged on the release channel and is pending relman signoff in Balrog once QA is happy.

Comment 9

[Mike Taylor [:miketaylr]]

Luciana, can you please verify the addon on the test channel (release-sysaddon)?

Documenting test steps here, mostly for my own record:

1. Verify the 4.3.3 XPI appears in https://aus5.mozilla.org/update/3/SystemAddons/68.0/20190705220548/Darwin_x86_64-gcc3/en-US/release-sysaddon/Darwin%2018.6.0/default/default/update.xml
2. change the update channel to "release-sysaddon" from the "channel-pref.js" file inside the Firefox directory.
3. Force an add-on update check by running this snippet in the browser console: Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();
4. restart the browser.
5. Re-run the tests to verify the addon worked.

Comment 10

[Dennis Schubert [:denschub]]

Wei, the .xpi seems to be signed with the cert for privileged extension instead of the cert for system addons. We receive "Add-on [e-mail] is not correctly signed." in the console, and openssl asn1parse -inform DER -in META-INF/mozilla.rsa shows a cert with organizationalUnitName="Mozilla Extensions", which doesn't seem right. Can you double-check please?

Comment 11

[:wezhou]

Hi Dennis,

When I sign an addon, I don't use OU as an input parameter, the input I use is a key. I guess the key may correspond to an OU in the backend.

That said, which OU would you like to see in the cert?

Comment 12

[Rehan Dalal (Inactive)]

It should be signed as a system addon (Mozilla Components key)

Comment 13

[:wezhou]

Attachment: signed.9077369.xpi

With :g-k's help, the file is signed again.

Please test.

Comment 14

[Mike Taylor [:miketaylr]]

Thanks. Rehan, can we get updated XPI staged to release-sysaddon again?

Comment 15

[Rehan Dalal (Inactive)]

The revised extension has been uploaded

Comment 16

[Luciana queirolo]

Hi,
Tried testing this on several OSes, On Windows 10 it worked (yay!) but it didn't on Ubuntu and MacOS .
What I did was:

1. Downloaded Release 68.0
2. Installed the build
3. Changed the channel to release-sysaddon.
4. Set the pref devtools.chrome.enabled to true.
5. Ran Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();
   Result:
   Got an error on the browser console, the labels were not displayed on the page and in about:support the Web Compat remain on 4.3.2 instead of changing to 4.3.3

Hope this helps!

Thanks!

Comment 17

[Mike Taylor [:miketaylr]]

Dennis was able to test successfully (without hitting the balrog CDN), but discovered Bug 1565673. While we investigate, let's pause here -- we may not want to pursue this if it breaks about:compat. Thanks for the help so far everyone.

Comment 18

[Mike Taylor [:miketaylr]]

Given that Bug 1565673 exists, I requested dot release ridealong in https://bugzilla.mozilla.org/show_bug.cgi?id=1563839. Let's go ahead and closer here -- I'm happy we discovered this bug!