1565090 - about:certificate has bad tab styling in dark mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Asif Youssuff]

Attachment: Screenshot from 2019-07-10 19-12-52.png

STR:

1. Ensure in content dark pages are enabled.
2. Navigate to about:certificate

What happens:

The tab0 and tab1 tabs (is this another bug?) look out of place in dark mode. This persists when a user hovers over the tabs.

Comment 1

[Johann Hofmann [:johannh]]

Danielle, can you take a look at this? :)

The tab0 and tab1 tabs (is this another bug?)

Nope, this is just not ready for public consumption yet.

Comment 2

[danielleleb12]

Yeah the tab names are just placeholders for the time being :) as for the colors, I'll do up a patch now. Thanks for pointing this out!

Comment 3

[danielleleb12]

Attachment: Bug 1565090 - Improves styling of certificate tabs in dark theme. r=johannh

Depends on D37745

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ea63057dda0
Improves styling of certificate tabs in dark theme. r=johannh

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ea63057dda0

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

Tested on the latest Fx71.0a1 in windows 10, Ubuntu 18 and macOS 10.13. On windows 10, it's been tested with windows dark mode as well, beside the firefox dark theme and there were no issues found.