Closed Bug 1565646 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17809 - Change test_designMode to check for empty string instead of br tag

Categories

(Testing :: geckodriver, task, P4)

Product:
Testing
Component:
geckodriver
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17809 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17809
Details from upstream follow.

Julian Kung <juliankung@chromium.org> wrote:

Change test_designMode to check for empty string instead of br tag

test_designMode incorrectly checks that the innerHTML after an element_clear is a <br> tag. Instead, the innerHTML property should be an empty string according to the W3C spec here: element clear.

The clear should follow the "To clear a content editable element" subroutine, which states:

  1. Set element’s innerHTML IDL attribute to an empty string.

Nowhere in the spec for element clear is the insertion of a <br> tag mentioned, so rather than accept both answers, to be spec compliant only an empty string should be accepted.

Component: web-platform-tests → geckodriver
Type: -- → task
Ran 1 tests and 81 subtests OK : 1 PASS : 80 FAIL : 1 Existing tests that now have a worse result (e.g. they used to PASS and now FAIL): /webdriver/tests/element_clear/clear.py test_designmode: FAIL
Blocks: 1573801

James, any idea why the stability try push didn't fail even once for the expected perma failure?

Flags: needinfo?(james)

Because the stability try push has the metadata updated from the initial try push, so the failure looks expected.

Flags: needinfo?(james)

Ah ok, thanks. We actually have to get this PR backed-out again, so hopefully the downstream sync will still take a bit.

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5da004d349e7 [wpt PR 17809] - Change test_designMode to check for empty string instead of br tag, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb24d7038e6 [wpt PR 17809] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5da004d349e7
https://hg.mozilla.org/mozilla-central/rev/9bb24d7038e6

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.