1565687 - Toggle password button doesn't work in about:logins

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: image.png

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Can you find when this regressed? I thought we had an automated test for this. The screenshot doesn't show any bug by the way. The eye is supposed to be opened when the characters are hidden.

Comment 2

[Tim Nguyen :ntim]

Attachment: image.png

Comment 3

[Tim Nguyen :ntim]

This is the smallest regression range I could find: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac50a7bd09b0a9262eed73f9dee2ffbd0e1a33b2&tochange=b7030ce607ec56690829e8fb6dbcd27dd54a044c

So it sounds like bug 1558242 ?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks, it was https://hg.mozilla.org/mozilla-central/rev/b979c5a32ffd19ab2502bcb07fb3e7c57863bb44

The event listener for .reveal-password-checkbox was not kept when changing how the event listeners were added.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1565687 - Add back the lost event listener for the reveal-password-checkbox and add some more tests for it. r?MattN

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30b8d57cb72a
Add back the lost event listener for the reveal-password-checkbox and add some more tests for it. r=MattN

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/30b8d57cb72a